address review: improve message in loghelper()

skirpichev · skirpichev · commit 8d28fd8cba17 · 2025-01-23T16:16:29.000+03:00
diff --git a/Lib/test/test_math.py b/Lib/test/test_math.py
@@ -2533,7 +2533,7 @@ def test_exception_messages(self):
             math.log(x)
         x = -123
         with self.assertRaisesRegex(ValueError,
-                                    f"expected a positive input"):
+                                    f"expected a positive input, got {x}"):
             math.log(x)
         with self.assertRaisesRegex(ValueError,
                                     f"expected a float or nonnegative integer, got {x}"):
diff --git a/Modules/mathmodule.c b/Modules/mathmodule.c
@@ -2232,8 +2232,8 @@ loghelper(PyObject* arg, double (*func)(double))
 
         /* Negative or zero inputs give a ValueError. */
         if (!_PyLong_IsPositive((PyLongObject *)arg)) {
-            PyErr_SetString(PyExc_ValueError,
-                            "expected a positive input");
+            PyErr_Format(PyExc_ValueError,
+                         "expected a positive input, got %S", arg);
             return NULL;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -2232,8 +2232,8 @@ loghelper(PyObject* arg, double (*func)(double))`
`2232`	`2232`
`2233`	`2233`	`/* Negative or zero inputs give a ValueError. */`
`2234`	`2234`	`if (!_PyLong_IsPositive((PyLongObject *)arg)) {`
`2235`		`- PyErr_SetString(PyExc_ValueError,`
`2236`		`- "expected a positive input");`
	`2235`	`+ PyErr_Format(PyExc_ValueError,`
	`2236`	`+ "expected a positive input, got %S", arg);`
`2237`	`2237`	`return NULL;`
`2238`	`2238`	`}`
`2239`	`2239`