Close file objects after reading contents

s3bw · s3bw · commit 8c3991b332b6 · 2020-07-29T19:18:20.000+01:00
Using both pickle and pickletools from the
    command line raised a resource warning
    indicating that the file objects were not
    closed after use.
diff --git a/Lib/pickle.py b/Lib/pickle.py
@@ -1814,4 +1814,5 @@ def _test():
             import pprint
             for f in args.pickle_file:
                 obj = load(f)
+                f.close()
                 pprint.pprint(obj)
diff --git a/Lib/pickletools.py b/Lib/pickletools.py
@@ -2882,9 +2882,11 @@ def _test():
         elif len(args.pickle_file) == 1:
             dis(args.pickle_file[0], args.output, None,
                 args.indentlevel, annotate)
+            args.pickle_file[0].close()
         else:
             memo = {} if args.memo else None
             for f in args.pickle_file:
                 preamble = args.preamble.format(name=f.name)
                 args.output.write(preamble + '\n')
                 dis(f, args.output, memo, args.indentlevel, annotate)
+                f.close()
