test_cext, test_cppext: enable /W4 warnings on Windows (#124253)

vstinner · web-flow · commit 7a2d77c903f2 · 2024-09-19T22:32:01.000+02:00
Add an explicit cast to (void*) and add Py_UNUSED() to fix some
warnings in extension.c.
diff --git a/Lib/test/test_cext/extension.c b/Lib/test/test_cext/extension.c
@@ -37,7 +37,13 @@ static PyMethodDef _testcext_methods[] = {
 
 
 static int
-_testcext_exec(PyObject *module)
+_testcext_exec(
+#ifdef __STDC_VERSION__
+    PyObject *module
+#else
+    PyObject *Py_UNUSED(module)
+#endif
+    )
 {
 #ifdef __STDC_VERSION__
     if (PyModule_AddIntMacro(module, __STDC_VERSION__) < 0) {
@@ -53,7 +59,7 @@ _testcext_exec(PyObject *module)
 }
 
 static PyModuleDef_Slot _testcext_slots[] = {
-    {Py_mod_exec, _testcext_exec},
+    {Py_mod_exec, (void*)_testcext_exec},
     {0, NULL}
 };
 
diff --git a/Lib/test/test_cext/setup.py b/Lib/test/test_cext/setup.py
@@ -31,6 +31,8 @@
 else:
     # MSVC compiler flags
     CFLAGS = [
+        # Display warnings level 1 to 4
+        '/W4',
         # Treat all compiler warnings as compiler errors
         '/WX',
     ]
diff --git a/Lib/test/test_cppext/setup.py b/Lib/test/test_cppext/setup.py
@@ -22,6 +22,8 @@
 else:
     # MSVC compiler flags
     CPPFLAGS = [
+        # Display warnings level 1 to 4
+        '/W4',
         # Treat all compiler warnings as compiler errors
         '/WX',
     ]

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,8 @@`
`31`	`31`	`else:`
`32`	`32`	`# MSVC compiler flags`
`33`	`33`	`CFLAGS = [`
	`34`	`+ # Display warnings level 1 to 4`
	`35`	`+ '/W4',`
`34`	`36`	`# Treat all compiler warnings as compiler errors`
`35`	`37`	`'/WX',`
`36`	`38`	`]`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,8 @@`
`22`	`22`	`else:`
`23`	`23`	`# MSVC compiler flags`
`24`	`24`	`CPPFLAGS = [`
	`25`	`+ # Display warnings level 1 to 4`
	`26`	`+ '/W4',`
`25`	`27`	`# Treat all compiler warnings as compiler errors`
`26`	`28`	`'/WX',`
`27`	`29`	`]`