bpo-33936: Don't call obsolete init methods with OpenSSL 1.1.0+ (GH-16140)

tiran · miss-islington · commit 724f1a57231f · 2019-09-16T12:10:05.000-07:00
``OPENSSL_VERSION_1_1`` was never defined in ``_hashopenssl.c``. https://bugs.python.org/issue33936
diff --git a/Misc/NEWS.d/next/Library/2019-09-14-10-34-00.bpo-33936.8wCI_n.rst b/Misc/NEWS.d/next/Library/2019-09-14-10-34-00.bpo-33936.8wCI_n.rst
@@ -0,0 +1,2 @@
+_hashlib no longer calls obsolete OpenSSL initialization function with
+OpenSSL 1.1.0+.
diff --git a/Modules/_hashopenssl.c b/Modules/_hashopenssl.c
@@ -1138,7 +1138,7 @@ PyInit__hashlib(void)
 {
     PyObject *m, *openssl_md_meth_names;
 
-#ifndef OPENSSL_VERSION_1_1
+#if (OPENSSL_VERSION_NUMBER < 0x10100000L) || defined(LIBRESSL_VERSION_NUMBER)
     /* Load all digest algorithms and initialize cpuid */
     OPENSSL_add_all_algorithms_noconf();
     ERR_load_crypto_strings();

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+_hashlib no longer calls obsolete OpenSSL initialization function with`
	`2`	`+OpenSSL 1.1.0+.`
Original file line number	Diff line number	Diff line change
`@@ -1138,7 +1138,7 @@ PyInit__hashlib(void)`
`1138`	`1138`	`{`
`1139`	`1139`	`PyObject m, openssl_md_meth_names;`
`1140`	`1140`
`1141`		`-#ifndef OPENSSL_VERSION_1_1`
	`1141`	`+#if (OPENSSL_VERSION_NUMBER < 0x10100000L) \|\| defined(LIBRESSL_VERSION_NUMBER)`
`1142`	`1142`	`/* Load all digest algorithms and initialize cpuid */`
`1143`	`1143`	`OPENSSL_add_all_algorithms_noconf();`
`1144`	`1144`	`ERR_load_crypto_strings();`