[3.12] gh-131762: Fixed dereferencing the pointer 'parser_token->metadata' with a NULL value (GH-131764) (#131775)

miss-islington · rialbat · web-flow · commit 66042e180b1d · 2025-03-26T19:01:36.000Z
gh-131762: Fixed dereferencing the pointer 'parser_token->metadata' with a NULL value (GH-131764) (cherry picked from commit 2c686a9) Co-authored-by: rialbat <47256826+rialbat@users.noreply.github.com>
diff --git a/Parser/pegen.c b/Parser/pegen.c
@@ -244,7 +244,7 @@ initialize_token(Parser *p, Token *parser_token, struct token *new_token, int to
     parser_token->metadata = NULL;
     if (new_token->metadata != NULL) {
         if (_PyArena_AddPyObject(p->arena, new_token->metadata) < 0) {
-            Py_DECREF(parser_token->metadata);
+            Py_DECREF(new_token->metadata);
             return -1;
         }
         parser_token->metadata = new_token->metadata;

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ initialize_token(Parser p, Token parser_token, struct token *new_token, int to`
`244`	`244`	`parser_token->metadata = NULL;`
`245`	`245`	`if (new_token->metadata != NULL) {`
`246`	`246`	`if (_PyArena_AddPyObject(p->arena, new_token->metadata) < 0) {`
`247`		`- Py_DECREF(parser_token->metadata);`
	`247`	`+ Py_DECREF(new_token->metadata);`
`248`	`248`	`return -1;`
`249`	`249`	`}`
`250`	`250`	`parser_token->metadata = new_token->metadata;`