gh-74929: Remove undesirable DECREF in PEP 667 implementation (#118583)

gaogaotiantian · web-flow · commit 5dd36732c850 · 2024-05-05T03:06:42.000Z
With tests.
diff --git a/Lib/test/test_frame.py b/Lib/test/test_frame.py
@@ -364,6 +364,21 @@ def f():
             c = 0
         f()
 
+    def test_local_objects(self):
+        o = object()
+        k = '.'.join(['a', 'b', 'c'])
+        f_locals = sys._getframe().f_locals
+        f_locals['o'] = f_locals['k']
+        self.assertEqual(o, 'a.b.c')
+
+    def test_update_with_self(self):
+        def f():
+            f_locals = sys._getframe().f_locals
+            f_locals.update(f_locals)
+            f_locals.update(f_locals)
+            f_locals.update(f_locals)
+        f()
+
     def test_repr(self):
         x = 1
         # Introduce a reference cycle
diff --git a/Objects/frameobject.c b/Objects/frameobject.c
@@ -171,7 +171,6 @@ framelocalsproxy_setitem(PyObject *self, PyObject *key, PyObject *value)
             } else if (value != oldvalue) {
                 Py_XSETREF(fast[i], Py_NewRef(value));
             }
-            Py_XDECREF(value);
             return 0;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,6 @@ framelocalsproxy_setitem(PyObject self, PyObject key, PyObject *value)`
`171`	`171`	`} else if (value != oldvalue) {`
`172`	`172`	`Py_XSETREF(fast[i], Py_NewRef(value));`
`173`	`173`	`}`
`174`		`- Py_XDECREF(value);`
`175`	`174`	`return 0;`
`176`	`175`	`}`
`177`	`176`	`}`