gh-133580: Add missing exception to _sys_getwindowsversion_from_kernel32 (GH-133574)

maxbachmann · web-flow · commit 5d118d0a9223 · 2025-05-14T14:10:35.000+01:00
diff --git a/Misc/NEWS.d/next/Windows/2025-05-07-13-04-22.gh-issue-133580.jBMujJ.rst b/Misc/NEWS.d/next/Windows/2025-05-07-13-04-22.gh-issue-133580.jBMujJ.rst
@@ -0,0 +1 @@
+Fix :func:`sys.getwindowsversion` failing without setting an exception when called on some WinAPI partitions.
diff --git a/Python/sysmodule.c b/Python/sysmodule.c
@@ -1643,6 +1643,7 @@ static PyObject *
 _sys_getwindowsversion_from_kernel32(void)
 {
 #ifndef MS_WINDOWS_DESKTOP
+    PyErr_SetString(PyExc_OSError, "cannot read version info on this platform");
     return NULL;
 #else
     HANDLE hKernel32;

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix :func:`sys.getwindowsversion` failing without setting an exception when called on some WinAPI partitions.
Original file line number	Diff line number	Diff line change
`@@ -1643,6 +1643,7 @@ static PyObject *`
`1643`	`1643`	`_sys_getwindowsversion_from_kernel32(void)`
`1644`	`1644`	`{`
`1645`	`1645`	`#ifndef MS_WINDOWS_DESKTOP`
	`1646`	`+ PyErr_SetString(PyExc_OSError, "cannot read version info on this platform");`
`1646`	`1647`	`return NULL;`
`1647`	`1648`	`#else`
`1648`	`1649`	`HANDLE hKernel32;`