8000 bpo-45187: Collect test_socket tests using unittest (GH-28317) · python/cpython@5a5684a · GitHub
[go: up one dir, main page]

Skip to content

Commit 5a5684a

Browse files
bpo-45187: Collect test_socket tests using unittest (GH-28317)
Previously, test classes ISOTPTest, J1939Test, BasicUDPLITETest and UDPLITETimeoutTest were not included in the list of tests and were not run by regrtest. (cherry picked from commit 0361335) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
1 parent ce59ac9 commit 5a5684a

File tree

1 file changed

+5
-79
lines changed

1 file changed

+5
-79
lines changed

Lib/test/test_socket.py

Lines changed: 5 additions & 79 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ def setUp(self):
199199
self.serv = socket.socket(socket.AF_INET, socket.SOCK_DGRAM, socket.IPPROTO_UDPLITE)
200200
self.port = socket_helper.bind_port(self.serv)
201201

202-
class ThreadSafeCleanupTestCase(unittest.TestCase):
202+
class ThreadSafeCleanupTestCase:
203203
"""Subclass of unittest.TestCase with thread-safe cleanup methods.
204204
205205
This subclass protects the addCleanup() and doCleanups() methods
@@ -4413,7 +4413,7 @@ class RecvmsgIntoSCMRightsStreamTest(RecvmsgIntoMixin, SCMRightsTest,
44134413
# threads alive during the test so that the OS cannot deliver the
44144414
# signal to the wrong one.
44154415

4416-
class InterruptedTimeoutBase(unittest.TestCase):
4416+
class InterruptedTimeoutBase:
44174417
# Base class for interrupted send/receive tests. Installs an
44184418
# empty handler for SIGALRM and removes it on teardown, along with
44194419
# any scheduled alarms.
@@ -6601,84 +6601,10 @@ def close_fds(fds):
66016601
self.assertEqual(data, str(index).encode())
66026602

66036603

6604-
def test_main():
6605-
tests = [GeneralModuleTests, BasicTCPTest, TCPCloserTest, TCPTimeoutTest,
6606-
TestExceptions, BufferIOTest, BasicTCPTest2, BasicUDPTest,
6607-
UDPTimeoutTest, CreateServerTest, CreateServerFunctionalTest,
6608-
SendRecvFdsTests]
6609-
6610-
tests.extend([
6611-
NonBlockingTCPTests,
6612-
FileObjectClassTestCase,
6613-
UnbufferedFileObjectClassTestCase,
6614-
LineBufferedFileObjectClassTestCase,
6615-
SmallBufferedFileObjectClassTestCase,
6616-
UnicodeReadFileObjectClassTestCase,
6617-
UnicodeWriteFileObjectClassTestCase,
6618-
UnicodeReadWriteFileObjectClassTestCase,
6619-
NetworkConnectionNoServer,
6620-
NetworkConnectionAttributesTest,
6621-
NetworkConnectionBehaviourTest,
6622-
ContextManagersTest,
6623-
InheritanceTest,
6624-
NonblockConstantTest
6625-
])
6626-
tests.append(BasicSocketPairTest)
6627-
tests.append(TestUnixDomain)
6628-
tests.append(TestLinuxAbstractNamespace)
6629-
tests.extend([TIPCTest, TIPCThreadableTest])
6630-
tests.extend([BasicCANTest, CANTest])
6631-
tests.extend([BasicRDSTest, RDSTest])
6632-
tests.append(LinuxKernelCryptoAPI)
6633-
tests.append(BasicQIPCRTRTest)
6634-
tests.extend([
6635-
BasicVSOCKTest,
6636-
ThreadedVSOCKSocketStreamTest,
6637-
])
6638-
tests.append(BasicBluetoothTest)
6639-
tests.extend([
6640-
CmsgMacroTests,
6641-
SendmsgUDPTest,
6642-
RecvmsgUDPTest,
6643-
RecvmsgIntoUDPTest,
6644-
SendmsgUDP6Test,
6645-
RecvmsgUDP6Test,
6646-
RecvmsgRFC3542AncillaryUDP6Test,
6647-
RecvmsgIntoRFC3542AncillaryUDP6Test,
6648-
RecvmsgIntoUDP6Test,
6649-
SendmsgUDPLITETest,
6650-
RecvmsgUDPLITETest,
6651-
RecvmsgIntoUDPLITETest,
6652-
SendmsgUDPLITE6Test,
6653-
RecvmsgUDPLITE6Test,
6654-
RecvmsgRFC3542AncillaryUDPLITE6Test,
6655-
RecvmsgIntoRFC3542AncillaryUDPLITE6Test,
6656-
RecvmsgIntoUDPLITE6Test,
6657-
SendmsgTCPTest,
6658-
RecvmsgTCPTest,
6659-
RecvmsgIntoTCPTest,
6660-
SendmsgSCTPStreamTest,
6661-
RecvmsgSCTPStreamTest,
6662-
RecvmsgIntoSCTPStreamTest,
6663-
SendmsgUnixStreamTest,
6664-
RecvmsgUnixStreamTest,
6665-
RecvmsgIntoUnixStreamTest,
6666-
RecvmsgSCMRightsStreamTest,
6667-
RecvmsgIntoSCMRightsStreamTest,
6668-
# These are slow when setitimer() is not available
6669-
InterruptedRecvTimeoutTest,
6670-
InterruptedSendTimeoutTest,
6671-
TestSocketSharing,
6672-
SendfileUsingSendTest,
6673-
SendfileUsingSendfileTest,
6674-
])
6675-
tests.append(TestMSWindowsTCPFlags)
6676-
tests.append(TestMacOSTCPFlags)
6677-
6604+
def setUpModule():
66786605
thread_info = threading_helper.threading_setup()
6679-
support.run_unittest(*tests)
6680-
threading_helper.threading_cleanup(*thread_info)
6606+
unittest.addModuleCleanup(threading_helper.threading_cleanup, *thread_info)
66816607

66826608

66836609
if __name__ == "__main__":
6684-
test_main()
6610+
unittest.main()

0 commit comments

Comments
 (0)
0