bpo-43651: Fix EncodingWarning in test_file and test_file_eintr (GH-25109)

methane · web-flow · commit 55f31be44b7e · 2021-04-01T11:23:03.000+09:00
diff --git a/Lib/test/test_file.py b/Lib/test/test_file.py
@@ -52,7 +52,7 @@ def testReadinto_text(self):
         # verify readinto refuses text files
         a = array('b', b'x'*10)
         self.f.close()
-        self.f = self.open(TESTFN, 'r')
+        self.f = self.open(TESTFN, encoding="utf-8")
         if hasattr(self.f, "readinto"):
             self.assertRaises(TypeError, self.f.readinto, a)
 
diff --git a/Lib/test/test_file_eintr.py b/Lib/test/test_file_eintr.py
@@ -213,7 +213,7 @@ class TestTextIOSignalInterrupt(TestFileIOSignalInterrupt):
     def _generate_infile_setup_code(self):
         """Returns the infile = ... line of code to make a TextIOWrapper."""
         return ('import %s as io ;'
-                'infile = io.open(sys.stdin.fileno(), "rt", newline=None) ;'
+                'infile = io.open(sys.stdin.fileno(), encoding="utf-8", newline=None) ;'
                 'assert isinstance(infile, io.TextIOWrapper)' %
                 self.modname)
 

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ def testReadinto_text(self):`
`52`	`52`	`# verify readinto refuses text files`
`53`	`53`	`a = array('b', b'x'*10)`
`54`	`54`	`self.f.close()`
`55`		`- self.f = self.open(TESTFN, 'r')`
	`55`	`+ self.f = self.open(TESTFN, encoding="utf-8")`
`56`	`56`	`if hasattr(self.f, "readinto"):`
`57`	`57`	`self.assertRaises(TypeError, self.f.readinto, a)`
`58`	`58`