8000 Accessing a single element should optimistically avoid locking for pe… · python/cpython@54095de · GitHub
[go: up one dir, main page]

Skip to content

Commit 54095de

Browse files
committed
Accessing a single element should optimistically avoid locking for performance
1 parent 11ac6f5 commit 54095de

File tree

3 files changed

+507
-131
lines changed

3 files changed

+507
-131
lines changed

Include/internal/pycore_dict.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,8 @@ static inline PyDictUnicodeEntry* DK_UNICODE_ENTRIES(PyDictKeysObject *dk) {
210210
#define DICT_VERSION_INCREMENT (1 << (DICT_MAX_WATCHERS + DICT_WATCHED_MUTATION_BITS))
211211
#define DICT_WATCHER_MASK ((1 << DICT_MAX_WATCHERS) - 1)
212212

213+
#define DICT_VALUES_SIZE(values) ((uint8_t *)values)[-1]
214+
213215
#ifdef Py_GIL_DISABLED
214216
#define DICT_NEXT_VERSION(INTERP) \
215217
(_Py_atomic_add_uint64(&(INTERP)->dict_state.global_version, DICT_VERSION_INCREMENT) + DICT_VERSION_INCREMENT)
@@ -255,7 +257,7 @@ _PyDictValues_AddToInsertionOrder(PyDictValues *values, Py_ssize_t ix)
255257
assert(ix < SHARED_KEYS_MAX_SIZE);
256258
uint8_t *size_ptr = ((uint8_t *)values)-2;
257259
int size = *size_ptr;
258-
assert(size+2 < ((uint8_t *)values)[-1]);
260+
assert(size+2 < DICT_VALUES_SIZE(values));
259261
size++;
260262
size_ptr[-size] = (uint8_t)ix;
261263
*size_ptr = size;

Objects/clinic/dictobject.c.h

Lines changed: 1 addition & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)
0