gh-131261: expat/refresh.sh: Expand list of manual steps (GH-131359)

encukou · web-flow · commit 51d309988b30 · 2025-03-18T13:17:43.000+01:00
diff --git a/Misc/sbom.spdx.json b/Misc/sbom.spdx.json
diff --git a/Modules/expat/refresh.sh b/Modules/expat/refresh.sh
@@ -54,4 +54,13 @@ rm libexpat.tar.gz
 # Step 3: Add the namespacing include to expat_external.h
 sed -i 's/#define Expat_External_INCLUDED 1/&\n\n\/* Namespace external symbols to allow multiple libexpat version to\n   co-exist. \*\/\n#include "pyexpatns.h"/' expat_external.h
 
-echo "Updated; verify all is okay using git diff and git status."
+echo "
+Updated! next steps:
+- Verify all is okay:
+    git diff
+    git status
+- Regenerate the sbom file
+    make regen-sbom
+- Update warning count in Tools/build/.warningignore_macos
+    (use info from CI if not on a Mac)
+"
diff --git a/Tools/build/generate_sbom.py b/Tools/build/generate_sbom.py
@@ -60,7 +60,7 @@ class PackageFiles(typing.NamedTuple):
         exclude=[
             "Modules/expat/expat_config.h",
             "Modules/expat/pyexpatns.h",
-            "Modules/_hacl/refresh.sh",
+            "Modules/expat/refresh.sh",
         ]
     ),
     "macholib": PackageFiles(

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ class PackageFiles(typing.NamedTuple):`
`60`	`60`	`exclude=[`
`61`	`61`	`"Modules/expat/expat_config.h",`
`62`	`62`	`"Modules/expat/pyexpatns.h",`
`63`		`- "Modules/_hacl/refresh.sh",`
	`63`	`+ "Modules/expat/refresh.sh",`
`64`	`64`	`]`
`65`	`65`	`),`
`66`	`66`	`"macholib": PackageFiles(`