bpo-32215: Fix performance regression in sqlite3 (GH-8511)

miss-islington · berkerpeksag · berkerpeksag · commit 4fb672ff96ec · 2018-09-20T20:19:50.000+03:00
(cherry picked from commit 8d1e190) Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
diff --git a/Misc/NEWS.d/next/Library/2018-07-28-12-08-53.bpo-32215.EU68SY.rst b/Misc/NEWS.d/next/Library/2018-07-28-12-08-53.bpo-32215.EU68SY.rst
@@ -0,0 +1,2 @@
+Fix performance regression in :mod:`sqlite3` when a DML statement appeared
+in a different line than the rest of the SQL query.
diff --git a/Modules/_sqlite/statement.c b/Modules/_sqlite/statement.c
@@ -85,10 +85,10 @@ int pysqlite_statement_create(pysqlite_Statement* self, pysqlite_Connection* con
                 continue;
         }
 
-        self->is_dml = (PyOS_strnicmp(p, "insert ", 7) == 0)
-                    || (PyOS_strnicmp(p, "update ", 7) == 0)
-                    || (PyOS_strnicmp(p, "delete ", 7) == 0)
-                    || (PyOS_strnicmp(p, "replace ", 8) == 0);
+        self->is_dml = (PyOS_strnicmp(p, "insert", 6) == 0)
+                    || (PyOS_strnicmp(p, "update", 6) == 0)
+                    || (PyOS_strnicmp(p, "delete", 6) == 0)
+                    || (PyOS_strnicmp(p, "replace", 7) == 0);
         break;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Fix performance regression in :mod:`sqlite3` when a DML statement appeared
	`2`	`+in a different line than the rest of the SQL query.`
Original file line number	Diff line number	Diff line change
`@@ -85,10 +85,10 @@ int pysqlite_statement_create(pysqlite_Statement* self, pysqlite_Connection* con`
`85`	`85`	`continue;`
`86`	`86`	`}`
`87`	`87`
`88`		`- self->is_dml = (PyOS_strnicmp(p, "insert ", 7) == 0)`
`89`		`- \|\| (PyOS_strnicmp(p, "update ", 7) == 0)`
`90`		`- \|\| (PyOS_strnicmp(p, "delete ", 7) == 0)`
`91`		`- \|\| (PyOS_strnicmp(p, "replace ", 8) == 0);`
	`88`	`+ self->is_dml = (PyOS_strnicmp(p, "insert", 6) == 0)`
	`89`	`+ \|\| (PyOS_strnicmp(p, "update", 6) == 0)`
	`90`	`+ \|\| (PyOS_strnicmp(p, "delete", 6) == 0)`
	`91`	`+ \|\| (PyOS_strnicmp(p, "replace", 7) == 0);`
`92`	`92`	`break;`
`93`	`93`	`}`
`94`	`94`