gh-128100: Use atomic dictionary load in _PyObject_GenericGetAttrWithDict (GH-128297)

wrongnull · web-flow · commit 47d2cb8eb759 · 2024-12-30T20:38:49.000Z
diff --git a/Objects/object.c b/Objects/object.c
@@ -1717,7 +1717,11 @@ _PyObject_GenericGetAttrWithDict(PyObject *obj, PyObject *name,
         else {
             PyObject **dictptr = _PyObject_ComputedDictPointer(obj);
             if (dictptr) {
+#ifdef Py_GIL_DISABLED
+                dict = _Py_atomic_load_ptr_acquire(dictptr);
+#else
                 dict = *dictptr;
+#endif
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -1717,7 +1717,11 @@ _PyObject_GenericGetAttrWithDict(PyObject obj, PyObject name,`
`1717`	`1717`	`else {`
`1718`	`1718`	`PyObject **dictptr = _PyObject_ComputedDictPointer(obj);`
`1719`	`1719`	`if (dictptr) {`
	`1720`	`+#ifdef Py_GIL_DISABLED`
	`1721`	`+ dict = _Py_atomic_load_ptr_acquire(dictptr);`
	`1722`	`+#else`
`1720`	`1723`	`dict = *dictptr;`
	`1724`	`+#endif`
`1721`	`1725`	`}`
`1722`	`1726`	`}`
`1723`	`1727`	`}`