[3.12] gh-120244: Fix re.sub() reference leak (GH-120245) (GH-120265)

miss-islington · neonene · web-flow · commit 46e69f8c2568 · 2024-06-08T14:10:44.000+03:00
(cherry picked from commit 38a25e9) Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
diff --git a/Misc/NEWS.d/next/Library/2024-06-08-09-45-31.gh-issue-120244.8o9Dzr.rst b/Misc/NEWS.d/next/Library/2024-06-08-09-45-31.gh-issue-120244.8o9Dzr.rst
@@ -0,0 +1 @@
+Fix memory leak in :func:`re.sub()` when the replacement string contains backreferences.
diff --git a/Modules/_sre/sre.c b/Modules/_sre/sre.c
@@ -1572,6 +1572,7 @@ _sre_template_impl(PyObject *module, PyObject *pattern, PyObject *template)
         }
         self->items[i].literal = Py_XNewRef(literal);
     }
+    PyObject_GC_Track(self);
     return (PyObject*) self;
 
 bad_template:

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix memory leak in :func:`re.sub()` when the replacement string contains backreferences.
Original file line number	Diff line number	Diff line change
`@@ -1572,6 +1572,7 @@ _sre_template_impl(PyObject module, PyObject pattern, PyObject *template)`
`1572`	`1572`	`}`
`1573`	`1573`	`self->items[i].literal = Py_XNewRef(literal);`
`1574`	`1574`	`}`
	`1575`	`+ PyObject_GC_Track(self);`
`1575`	`1576`	`return (PyObject*) self;`
`1576`	`1577`
`1577`	`1578`	`bad_template:`