Issue #25081: Makes Back button in installer go back to upgrade page when upgrading.

zooba · zooba · commit 44fe401aa3af · 2015-09-22T16:36:33.000-07:00
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -150,6 +150,9 @@ Build
 Windows
 -------
 
+- Issue #25081: Makes Back button in installer go back to upgrade page when
+  upgrading.
+
 - Issue #25091: Increases font size of the installer.
 
 - Issue #25126: Clarifies that the non-web installer will download some
diff --git a/Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp b/Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp
@@ -323,6 +323,8 @@ class PythonBootstrapperApplication : public CBalBaseBootstrapperApplication {
             SavePageSettings();
             if (_modifying) {
                 GoToPage(PAGE_MODIFY);
+            } else if (_upgrading) {
+                GoToPage(PAGE_UPGRADE);
             } else {
                 GoToPage(PAGE_INSTALL);
             }
@@ -2524,6 +2526,7 @@ class PythonBootstrapperApplication : public CBalBaseBootstrapperApplication {
                     case BOOTSTRAPPER_ACTION_INSTALL:
                         if (_upgradingOldVersion) {
                             _installPage = PAGE_UPGRADE;
+                            _upgrading = TRUE;
                         } else if (SUCCEEDED(BalGetNumericVariable(L"SimpleInstall", &simple)) && simple) {
                             _installPage = PAGE_SIMPLE_INSTALL;
                         } else {
@@ -3029,6 +3032,7 @@ class PythonBootstrapperApplication : public CBalBaseBootstrapperApplication {
         _suppressDowngradeFailure = FALSE;
         _suppressRepair = FALSE;
         _modifying = FALSE;
+        _upgrading = FALSE;
 
         _overridableVariables = nullptr;
         _taskbarList = nullptr;
@@ -3113,6 +3117,7 @@ class PythonBootstrapperApplication : public CBalBaseBootstrapperApplication {
     BOOL _suppressDowngradeFailure;
     BOOL _suppressRepair;
     BOOL _modifying;
+    BOOL _upgrading;
 
     int _crtInstalledToken;
 
