8000 Add Windows to the tailcall CI · python/cpython@3eb568f · GitHub
[go: up one dir, main page]
Skip to content

Commit 3eb568f

Browse files
Fidget-SpinnerFidget-Spinner
committed
Add Windows to the tailcall CI
1 parent d57c175 commit 3eb568f

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

‎.github/workflows/tail-call.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
target:
3636
# Un-comment as we add support for more platforms for tail-calling interpreters.
3737
# - i686-pc-windows-msvc/msvc
38-
# - x86_64-pc-windows-msvc/msvc
38+
- x86_64-pc-windows-msvc/msvc
3939
# - aarch64-pc-windows-msvc/msvc
4040
- x86_64-apple-darwin/clang
4141
- aarch64-apple-darwin/clang
@@ -47,9 +47,9 @@ jobs:
4747
# - target: i686-pc-windows-msvc/msvc
4848
# architecture: Win32
4949
# runner: windows-latest
50-
# - target: x86_64-pc-windows-msvc/msvc
51-
# architecture: x64
52-
# runner: windows-latest
50+
- target: x86_64-pc-windows-msvc/msvc
51+
architecture: x64
52+
runner: windows-latest
5353
# - target: aarch64-pc-windows-msvc/msvc
5454
# architecture: ARM64
5555
# runner: windows-latest
@@ -76,22 +76,22 @@ jobs:
7676
- name: Native Windows (debug)
7777
if: runner.os == 'Windows' && matrix.architecture != 'ARM64'
7878
run: |
79-
choco install llvm --allow-downgrade --no-progress --version ${{ matrix.llvm }}.1.0
80-
./PCbuild/build.bat --tail-call-interp -d -p ${{ matrix.architecture }}
79+
choco install llvm --allow-downgrade --no-progress --version ${{ matrix.llvm }}.1.5
80+
./PCbuild/build.bat --tail-call-interp -d -p ${{ matrix.architecture }} /p:PlatformToolset=clangcl /p:LLVMToolsVersion=19.1.5 /p:LLVMInstallDir=C:\Program Files\LLVM
8181
./PCbuild/rt.bat -d -p ${{ matrix.architecture }} -q --multiprocess 0 --timeout 4500 --verbose2 --verbose3
8282
8383
# No tests (yet):
8484
- name: Emulated Windows (release)
8585
if: runner.os == 'Windows' && matrix.architecture == 'ARM64'
8686
run: |
87-
choco install llvm --allow-downgrade --no-progress --version ${{ matrix.llvm }}.1.0
88-
./PCbuild/build.bat --tail-call-interp -p ${{ matrix.architecture }}
87+
choco install llvm --allow-downgrade --no-progress --version ${{ matrix.llvm }}.1.5
88+
./PCbuild/build.bat --tail-call-interp -p ${{ matrix.architecture }} /p:PlatformToolset=clangcl /p:LLVMToolsVersion=19.1.5 /p:LLVMInstallDir=C:\Program Files\LLVM
8989
9090
# The `find` line is required as a result of https://github.com/actions/runner-images/issues/9966.
9191
# This is a bug in the macOS runner image where the pre-installed Python is installed in the same
9292
# directory as the Homebrew Python, which causes the build to fail for macos-13. This line removes
9393
# the symlink to the pre-installed Python so that the Homebrew Python is used instead.
94-
- name: Native macOS (debug)
94+
- name: Native macOS (release)
9595
if: runner.os == 'macOS'
9696
run: |
9797
brew update
@@ -100,16 +100,16 @@ jobs:
100100
export SDKROOT="$(xcrun --show-sdk-path)"
101101
export PATH="/opt/homebrew/opt/llvm/bin:$PATH"
102102
export PATH="/usr/local/opt/llvm/bin:$PATH"
103-
CC=clang-19 ./configure --with-tail-call-interp --with-pydebug
103+
CC=clang-19 ./configure --with-tail-call-interp
104104
make all --jobs 4
105105
./python.exe -m test --multiprocess 0 --timeout 4500 --verbose2 --verbose3
106106
107-
- name: Native Linux (release)
107+
- name: Native Linux (debug)
108108
if: runner.os == 'Linux'
109109
run: |
110110
sudo bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)" ./llvm.sh ${{ matrix.llvm }}
111111
export PATH="$(llvm-config-${{ matrix.llvm }} --bindir):$PATH"
112-
CC=clang-19 ./configure --with-tail-call-interp
112+
CC=clang-19 ./configure --with-tail-call-interp --with-pydebug
113113
make all --jobs 4
114114
./python -m test --multiprocess 0 --timeout 4500 --verbose2 --verbose3
115115

0 commit comments

Comments
 (0)
0