8000 Apply suggestions from code review · python/cpython@3cdb8d9 · GitHub
[go: up one dir, main page]

Skip to content

Commit 3cdb8d9

Browse files
serhiy-storchakaJelleZijlstraAlexWaygood
authored
Apply suggestions from code review
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
1 parent 1cbc88d commit 3cdb8d9

File tree

5 files changed

+7
-5
lines changed

5 files changed

+7
-5
lines changed

Doc/c-api/object.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ Object Protocol
6565
6666
Properly handle returning :c:data:`Py_NotImplemented` from within a C
6767
function (that is, create a new :term:`strong reference`
68-
to ``NotImplemented`` and return it).
68+
to :const:`NotImplemented` and return it).
6969
7070
7171
.. c:macro:: Py_PRINT_RAW

Misc/NEWS.d/3.11.0b1.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -664,7 +664,8 @@ for :func:`os.fcopyfile` available in macOs.
664664
.. nonce: l1p7CJ
665665
.. section: Library
666666
667-
For ``@dataclass``, add ``weakref_slot``. Default is ``False``. If true, and if
667+
For :func:`@dataclass <dataclasses.dataclass>`, add *weakref_slot*.
668+
The new parameter defaults to ``False``. If true, and if
668669
``slots=True``, add a slot named ``"__weakref__"``, which will allow instances to be
669670
weakref'd. Contributed by Eric V. Smith
670671

Misc/NEWS.d/3.12.0a1.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3562,7 +3562,7 @@ with :func:`os.pidfd_open` in non-blocking mode. Patch by Kumar Aditya.
35623562
.. section: Library
35633563
35643564
Implement ``Enum.__contains__`` that returns ``True`` or ``False`` to replace the
3565-
deprecated behaviour that would sometimes raise a ``TypeError``.
3565+
deprecated behaviour that would sometimes raise a :exc:`TypeError`.
35663566

35673567
..
35683568

Misc/NEWS.d/3.13.0a1.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3436,7 +3436,8 @@ added support for this decorator. Patch by Alex Waygood.
34363436
.. nonce: C1ahtk
34373437
.. section: Library
34383438
3439-
Make :func:`pydoc.doc` catch bad module ``ImportError`` when output stream is not ``None``.
3439+
Make :func:`pydoc.doc` catch bad module :exc:`ImportError`
3440+
when output stream is not ``None``.
34403441

34413442
..
34423443

Misc/NEWS.d/3.13.0a2.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1355,7 +1355,7 @@ crash encountered after the first :meth:`tkinter.Tk` instance is destroyed.
13551355
13561356
Add docstrings to the IDLE debugger module. Fix two bugs: initialize
13571357
``Idb.botframe`` (should be in Bdb); in ``Idb.in_rpc_code``, check whether
1358-
``prev_frame is None`` before trying to use it. Greatly expand test_debugger.
1358+
``prev_frame`` is ``None`` before trying to use it. Greatly expand test_debugger.
13591359

13601360
..
13611361

0 commit comments

Comments
 (0)
0