Compat with other backends: silently coerce keys to bytes

erlend-aasland · erlend-aasland · commit 34930cb9fdc7 · 2024-02-14T11:50:11.000+01:00
diff --git a/Lib/dbm/sqlite3.py b/Lib/dbm/sqlite3.py
@@ -12,9 +12,9 @@
   )
 """
 GET_SIZE = "SELECT COUNT (key) FROM Dict"
-LOOKUP_KEY = "SELECT value FROM Dict WHERE key = ?"
+LOOKUP_KEY = "SELECT value FROM Dict WHERE key = CAST(? AS BLOB)"
 STORE_KV = "REPLACE INTO Dict (key, value) VALUES (CAST(? AS BLOB), CAST(? AS BLOB))"
-DELETE_KEY = "DELETE FROM Dict WHERE key = ?"
+DELETE_KEY = "DELETE FROM Dict WHERE key = CAST(? AS BLOB)"
 ITER_KEYS = "SELECT key FROM Dict"
 
 
diff --git a/Lib/test/test_dbm_sqlite3.py b/Lib/test/test_dbm_sqlite3.py
@@ -213,6 +213,7 @@ class DataTypes(_SQLiteDbmTests):
         (42, b"42"),
         (3.14, b"3.14"),
         ("string", b"string"),
+        (b"bytes", b"bytes"),
     )
 
     def setUp(self):
@@ -234,10 +235,15 @@ def test_datatypes_keys(self):
             with self.subTest(raw=raw, coerced=coerced):
                 self.db[raw] = "value"
                 self.assertEqual(self.db[coerced], b"value")
-                with self.assertRaises(KeyError):
-                    self.db[raw]
-                with self.assertRaises(KeyError):
-                    del self.db[raw]
+                # Raw keys are silently coerced to bytes.
+                self.assertEqual(self.db[raw], b"value")
+                del self.db[raw]
+
+    def test_datatypes_replace_coerced(self):
+        self.db["10"] = "value"
+        self.db[b"10"] = "value"
+        self.db[10] = "value"
+        self.assertEqual(self.db.keys(), [b"10"])
 
 
 class CorruptDatabase(_SQLiteDbmTests):
