8000 Apply suggestions from code review · python/cpython@31d0558 · GitHub
[go: up one dir, main page]

Skip to content

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 31d0558

Browse files
Apply suggestions from code review
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
1 parent 1faf4b0 commit 31d0558

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Doc/library/venv.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ creation according to their needs, the :class:`EnvBuilder` class.
143143

144144
.. class:: EnvBuilder(system_site_packages=False, clear=False, \
145145
symlinks=False, upgrade=False, with_pip=False, \
146-
prompt=None, upgrade_deps=False, \*, gitignore=False)
146+
prompt=None, upgrade_deps=False, *, gitignore=False)
147147
148148
The :class:`EnvBuilder` class accepts the following keyword arguments on
149149
instantiation:
@@ -350,7 +350,7 @@ There is also a module-level convenience function:
350350

351351
.. function:: create(env_dir, system_site_packages=False, clear=False, \
352352
symlinks=False, with_pip=False, prompt=None, \
353-
upgrade_deps=False, \*, gitignore=False)
353+
upgrade_deps=False, *, gitignore=False)
354354
355355
Create an :class:`EnvBuilder` with the given keyword arguments, and call its
356356
:meth:`~EnvBuilder.create` method with the *env_dir* argument.

Lib/test/test_venv.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ def test_config_file_command_key(self):
166166
b = venv.EnvBuilder()
167167
else:
168168
b = venv.EnvBuilder(
169-
**{attr: False if attr in negated_attrs else True})
169+
**{attr: attr not in negated_attrs})
170170
b.upgrade_dependencies = Mock() # avoid pip command to upgrade deps
171171
b._setup_pip = Mock() # avoid pip setup
172172
self.run_with_capture(b.create, self.env_dir)

0 commit comments

Comments
 (0)
0