8000 bpo-40636: Remove overly-strict zip pickling tests (GH-24109) · python/cpython@27f9daf · GitHub
[go: up one dir, main page]

Skip to content

Commit 27f9daf

Browse files
authored
bpo-40636: Remove overly-strict zip pickling tests (GH-24109)
1 parent cde988e commit 27f9daf

File tree

1 file changed

+0
-42
lines changed

1 file changed

+0
-42
lines changed

Lib/test/test_builtin.py

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -1621,48 +1621,6 @@ def test_zip_pickle_strict_fail(self):
16211621
self.assertEqual(self.iter_error(z1, ValueError), t)
16221622
self.assertEqual(self.iter_error(z2, ValueError), t)
16231623

1624-
def test_zip_pickle_stability(self):
1625-
# Pickles of zip((1, 2, 3), (4, 5, 6)) dumped from 3.9:
1626-
pickles = [
1627-
b'citertools\nizip\np0\n(c__builtin__\niter\np1\n((I1\nI2\nI3\ntp2\ntp3\nRp4\nI0\nbg1\n((I4\nI5\nI6\ntp5\ntp6\nRp7\nI0\nbtp8\nRp9\n.',
1628-
b'citertools\nizip\nq\x00(c__builtin__\niter\nq\x01((K\x01K\x02K\x03tq\x02tq\x03Rq\x04K\x00bh\x01((K\x04K\x05K\x06tq\x05tq\x06Rq\x07K\x00btq\x08Rq\t.',
1629-
b'\x80\x02citertools\nizip\nq\x00c__builtin__\niter\nq\x01K\x01K\x02K\x03\x87q\x02\x85q\x03Rq\x04K\x00bh\x01K\x04K\x05K\x06\x87q\x05\x85q\x06Rq\x07K\x00b\x86q\x08Rq\t.',
1630-
b'\x80\x03cbuiltins\nzip\nq\x00cbuiltins\niter\nq\x01K\x01K\x02K\x03\x87q\x02\x85q\x03Rq\x04K\x00bh\x01K\x04K\x05K\x06\x87q\x05\x85q\x06Rq\x07K\x00b\x86q\x08Rq\t.',
1631-
b'\x80\x04\x95L\x00\x00\x00\x00\x00\x00\x00\x8c\x08builtins\x94\x8c\x03zip\x94\x93\x94\x8c\x08builtins\x94\x8c\x04iter\x94\x93\x94K\x01K\x02K\x03\x87\x94\x85\x94R\x94K\x00bh\x05K\x04K\x05K\x06\x87\x94\x85\x94R\x94K\x00b\x86\x94R\x94.',
1632-
b'\x80\x05\x95L\x00\x00\x00\x00\x00\x00\x00\x8c\x08builtins\x94\x8c\x03zip\x94\x93\x94\x8c\x08builtins\x94\x8c\x04iter\x94\x93\x94K\x01K\x02K\x03\x87\x94\x85\x94R\x94K\x00bh\x05K\x04K\x05K\x06\x87\x94\x85\x94R\x94K\x00b\x86\x94R\x94.',
1633-
]
1634-
for protocol, dump in enumerate(pickles):
1635-
z1 = zip((1, 2, 3), (4, 5, 6))
1636-
z2 = zip((1, 2, 3), (4, 5, 6), strict=False)
1637-
z3 = pickle.loads(dump)
1638-
l3 = list(z3)
1639-
self.assertEqual(type(z3), zip)
1640-
self.assertEqual(pickle.dumps(z1, protocol), dump)
1641-
self.assertEqual(pickle.dumps(z2, protocol), dump)
1642-
self.assertEqual(list(z1), l3)
1643-
self.assertEqual(list(z2), l3)
1644-
1645-
def test_zip_pickle_strict_stability(self):
1646-
# Pickles of zip((1, 2, 3), (4, 5), strict=True) dumped from 3.10:
1647-
pickles = [
1648-
b'citertools\nizip\np0\n(c__builtin__\niter\np1\n((I1\nI2\nI3\ntp2\ntp3\nRp4\nI0\nbg1\n((I4\nI5\ntp5\ntp6\nRp7\nI0\nbtp8\nRp9\nI01\nb.',
1649-
b'citertools\nizip\nq\x00(c__builtin__\niter\nq\x01((K\x01K\x02K\x03tq\x02tq\x03Rq\x04K\x00bh\x01((K\x04K\x05tq\x05tq\x06Rq\x07K\x00btq\x08Rq\tI01\nb.',
1650-
b'\x80\x02citertools\nizip\nq\x00c__builtin__\niter\nq\x01K\x01K\x02K\x03\x87q\x02\x85q\x03Rq\x04K\x00bh\x01K\x04K\x05\x86q\x05\x85q\x06Rq\x07K\x00b\x86q\x08Rq\t\x88b.',
1651-
b'\x80\x03cbuiltins\nzip\nq\x00cbuiltins\niter\nq\x01K\x01K\x02K\x03\x87q\x02\x85q\x03Rq\x04K\x00bh\x01K\x04K\x05\x86q\x05\x85q\x06Rq\x07K\x00b\x86q\x08Rq\t\x88b.',
1652-
b'\x80\x04\x95L\x00\x00\x00\x00\x00\x00\x00\x8c\x08builtins\x94\x8c\x03zip\x94\x93\x94\x8c\x08builtins\x94\x8c\x04iter\x94\x93\x94K\x01K\x02K\x03\x87\x94\x85\x94R\x94K\x00bh\x05K\x04K\x05\x86\x94\x85\x94R\x94K\x00b\x86\x94R\x94\x88b.',
1653-
b'\x80\x05\x95L\x00\x00\x00\x00\x00\x00\x00\x8c\x08builtins\x94\x8c\x03zip\x94\x93\x94\x8c\x08builtins\x94\x8c\x04iter\x94\x93\x94K\x01K\x02K\x03\x87\x94\x85\x94R\x94K\x00bh\x05K\x04K\x05\x86\x94\x85\x94R\x94K\x00b\x86\x94R\x94\x88b.',
1654-
]
1655-
a = (1, 2, 3)
1656-
b = (4, 5)
1657-
t = [(1, 4), (2, 5)]
1658-
for protocol, dump in enumerate(pickles):
1659-
z1 = zip(a, b, strict=True)
1660-
z2 = pickle.loads(dump)
1661-
self.assertEqual(pickle.dumps(z1, protocol), dump)
1662-
self.assertEqual(type(z2), zip)
1663-
self.assertEqual(self.iter_error(z1, ValueError), t)
1664-
self.assertEqual(self.iter_error(z2, ValueError), t)
1665-
16661624
def test_zip_bad_iterable(self):
16671625
exception = TypeError()
16681626

0 commit comments

Comments
 (0)
0