Update function signatures and make files with expected warnings list a true set

nohlson · nohlson · commit 26b40d3727b5 · 2024-08-13T11:54:43.000-05:00
diff --git a/Tools/build/check_warnings.py b/Tools/build/check_warnings.py
@@ -115,7 +115,7 @@ def get_warnings_by_file(warnings: list[dict]) -> dict[str, list[dict]]:
 
 def get_unexpected_warnings(
     files_with_expected_warnings: set[tuple[str, int]],
-    files_with_warnings: dict[str, list[dict]],
+    files_with_warnings: set[FileWarnings],
 ) -> int:
     """
     Returns failure status if warnings discovered in list of warnings
@@ -145,7 +145,7 @@ def get_unexpected_warnings(
 
 def get_unexpected_improvements(
     files_with_expected_warnings: set[tuple[str, int]],
-    files_with_warnings: dict[str, list[dict]],
+    files_with_warnings: set[FileWarnings],
 ) -> int:
     """
     Returns failure status if there are no warnings in the list of warnings
@@ -155,8 +155,7 @@ def get_unexpected_improvements(
     for file in files_with_expected_warnings:
         if file.name not in files_with_warnings.keys():
             unexpected_improvements.append(file)
-        else:
-            if len(files_with_warnings[file.name]) < file.count:
+        elif len(files_with_warnings[file.name]) < file.count:
                 unexpected_improvements.append(file)
 
     if unexpected_improvements:
@@ -239,11 +238,11 @@ def main(argv: list[str] | None = None) -> int:
             # Files with expected warnings are stored as a set of tuples
             # where the first element is the file name and the second element
             # is the number of warnings expected in that file
-            files_with_expected_warnings = [
+            files_with_expected_warnings = {
                 FileWarnings(file.strip().split()[0], int(file.strip().split()[1]))
                 for file in clean_files
                 if file.strip() and not file.startswith("#")
-            ]
+            }
 
     with Path(args.compiler_output_file_path).open(encoding="UTF-8") as f:
         compiler_output_file_contents = f.read()
