gh-101609: Fix "‘state’ may be used uninitialized" warning in _xxinterpchannelsmodule (GH-101610)

sobolevn · web-flow · commit 262003fd3297 · 2023-02-06T13:05:41.000-08:00
I went with the easiest solution: just removing the offending line. See the issue description with my reasoning. #101609
diff --git a/Modules/_xxinterpchannelsmodule.c b/Modules/_xxinterpchannelsmodule.c
@@ -174,7 +174,9 @@ static int
 clear_module_state(module_state *state)
 {
     /* heap types */
-    (void)_PyCrossInterpreterData_UnregisterClass(state->ChannelIDType);
+    if (state->ChannelIDType != NULL) {
+        (void)_PyCrossInterpreterData_UnregisterClass(state->ChannelIDType);
+    }
     Py_CLEAR(state->ChannelIDType);
 
     /* exceptions */
@@ -2269,7 +2271,6 @@ module_exec(PyObject *mod)
     return 0;
 
 error:
-    (void)_PyCrossInterpreterData_UnregisterClass(state->ChannelIDType);
     _globals_fini();
     return -1;
 }
