Return a strong ref from _PyInterpolation_GetValue

lysnikolaou · lysnikolaou · commit 23444df35a5d · 2025-04-21T16:40:40.000+02:00
diff --git a/Include/internal/pycore_interpolation.h b/Include/internal/pycore_interpolation.h
@@ -18,7 +18,7 @@ extern PyTypeObject _PyInterpolation_Type;
 PyAPI_FUNC(PyObject *) _PyInterpolation_FromStackRefStealOnSuccess(_PyStackRef *values);
 
 extern PyStatus _PyInterpolation_InitTypes(PyInterpreterState *interp);
-extern PyObject *_PyInterpolation_GetValue(PyObject *interpolation);
+extern PyObject *_PyInterpolation_GetValueRef(PyObject *interpolation);
 
 #ifdef __cplusplus
 }
diff --git a/Objects/interpolationobject.c b/Objects/interpolationobject.c
@@ -184,7 +184,7 @@ _PyInterpolation_FromStackRefStealOnSuccess(_PyStackRef *values)
 }
 
 PyObject *
-_PyInterpolation_GetValue(PyObject *interpolation)
+_PyInterpolation_GetValueRef(PyObject *interpolation)
 {
-    return interpolationobject_CAST(interpolation)->value;
+    return Py_NewRef(interpolationobject_CAST(interpolation)->value);
 }
diff --git a/Objects/templateobject.c b/Objects/templateobject.c
@@ -437,7 +437,7 @@ template_values_get(PyObject *op, void *Py_UNUSED(data))
     PyObject *item;
     Py_ssize_t index = 0;
     while ((item = PyIter_Next(interpolationsiter))) {
-        PyTuple_SET_ITEM(values, index++, Py_NewRef(_PyInterpolation_GetValue(item)));
+        PyTuple_SET_ITEM(values, index++, _PyInterpolation_GetValueRef(item));
         Py_DECREF(item);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ extern PyTypeObject _PyInterpolation_Type;`
`18`	`18`	`PyAPI_FUNC(PyObject ) _PyInterpolation_FromStackRefStealOnSuccess(_PyStackRef values);`
`19`	`19`
`20`	`20`	`extern PyStatus _PyInterpolation_InitTypes(PyInterpreterState *interp);`
`21`		`-extern PyObject _PyInterpolation_GetValue(PyObject interpolation);`
	`21`	`+extern PyObject _PyInterpolation_GetValueRef(PyObject interpolation);`
`22`	`22`
`23`	`23`	`#ifdef __cplusplus`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ _PyInterpolation_FromStackRefStealOnSuccess(_PyStackRef *values)`
`184`	`184`	`}`
`185`	`185`
`186`	`186`	`PyObject *`
`187`		`-_PyInterpolation_GetValue(PyObject *interpolation)`
	`187`	`+_PyInterpolation_GetValueRef(PyObject *interpolation)`
`188`	`188`	`{`
`189`		`- return interpolationobject_CAST(interpolation)->value;`
	`189`	`+ return Py_NewRef(interpolationobject_CAST(interpolation)->value);`
`190`	`190`	`}`
Original file line number	Diff line number	Diff line change
`@@ -437,7 +437,7 @@ template_values_get(PyObject op, void Py_UNUSED(data))`
`437`	`437`	`PyObject *item;`
`438`	`438`	`Py_ssize_t index = 0;`
`439`	`439`	`while ((item = PyIter_Next(interpolationsiter))) {`
`440`		`- PyTuple_SET_ITEM(values, index++, Py_NewRef(_PyInterpolation_GetValue(item)));`
	`440`	`+ PyTuple_SET_ITEM(values, index++, _PyInterpolation_GetValueRef(item));`
`441`	`441`	`Py_DECREF(item);`
`442`	`442`	`}`
`443`	`443`