bpo-38823: Clean up refleaks in _contextvars initialization. (GH-17198)

miss-islington · brandtbucher · web-flow · commit 1fe79a43400d · 2019-11-16T16:16:33.000-08:00
https://bugs.python.org/issue38823 (cherry picked from commit 143a97f) Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
diff --git a/Modules/_contextvarsmodule.c b/Modules/_contextvarsmodule.c
@@ -52,6 +52,7 @@ PyInit__contextvars(void)
                            (PyObject *)&PyContext_Type) < 0)
     {
         Py_DECREF(&PyContext_Type);
+        Py_DECREF(m);
         return NULL;
     }
 
@@ -60,6 +61,7 @@ PyInit__contextvars(void)
                            (PyObject *)&PyContextVar_Type) < 0)
     {
         Py_DECREF(&PyContextVar_Type);
+        Py_DECREF(m);
         return NULL;
     }
 
@@ -68,6 +70,7 @@ PyInit__contextvars(void)
                            (PyObject *)&PyContextToken_Type) < 0)
     {
         Py_DECREF(&PyContextToken_Type);
+        Py_DECREF(m);
         return NULL;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,7 @@ PyInit__contextvars(void)`
`52`	`52`	`(PyObject *)&PyContext_Type) < 0)`
`53`	`53`	`{`
`54`	`54`	`Py_DECREF(&PyContext_Type);`
	`55`	`+ Py_DECREF(m);`
`55`	`56`	`return NULL;`
`56`	`57`	`}`
`57`	`58`
`@@ -60,6 +61,7 @@ PyInit__contextvars(void)`
`60`	`61`	`(PyObject *)&PyContextVar_Type) < 0)`
`61`	`62`	`{`
`62`	`63`	`Py_DECREF(&PyContextVar_Type);`
	`64`	`+ Py_DECREF(m);`
`63`	`65`	`return NULL;`
`64`	`66`	`}`
`65`	`67`
`@@ -68,6 +70,7 @@ PyInit__contextvars(void)`
`68`	`70`	`(PyObject *)&PyContextToken_Type) < 0)`
`69`	`71`	`{`
`70`	`72`	`Py_DECREF(&PyContextToken_Type);`
	`73`	`+ Py_DECREF(m);`
`71`	`74`	`return NULL;`
`72`	`75`	`}`
`73`	`76`