gh-133537: Avoid using console I/O in WinAPI partitions that don't support it (GH-133538)

maxbachmann · web-flow · commit 1460ccefd07f · 2025-05-07T20:47:05.000+01:00
diff --git a/Misc/NEWS.d/next/Windows/2025-05-07-08-19-15.gh-issue-133537.yzf963.rst b/Misc/NEWS.d/next/Windows/2025-05-07-08-19-15.gh-issue-133537.yzf963.rst
@@ -0,0 +1 @@
+Avoid using console I/O in WinAPI partitions that don’t support it
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
@@ -16875,12 +16875,16 @@ static PyObject *
 os__supports_virtual_terminal_impl(PyObject *module)
 /*[clinic end generated code: output=bd0556a6d9d99fe6 input=0752c98e5d321542]*/
 {
+#ifdef HAVE_WINDOWS_CONSOLE_IO
     DWORD mode = 0;
     HANDLE handle = GetStdHandle(STD_ERROR_HANDLE);
     if (!GetConsoleMode(handle, &mode)) {
         Py_RETURN_FALSE;
     }
     return PyBool_FromLong(mode & ENABLE_VIRTUAL_TERMINAL_PROCESSING);
+#else
+    Py_RETURN_FALSE;
+#endif /* HAVE_WINDOWS_CONSOLE_IO */
 }
 #endif
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Avoid using console I/O in WinAPI partitions that don’t support it`
Original file line number	Diff line number	Diff line change
`@@ -16875,12 +16875,16 @@ static PyObject *`
`16875`	`16875`	`os__supports_virtual_terminal_impl(PyObject *module)`
`16876`	`16876`	`/[clinic end generated code: output=bd0556a6d9d99fe6 input=0752c98e5d321542]/`
`16877`	`16877`	`{`
	`16878`	`+#ifdef HAVE_WINDOWS_CONSOLE_IO`
`16878`	`16879`	`DWORD mode = 0;`
`16879`	`16880`	`HANDLE handle = GetStdHandle(STD_ERROR_HANDLE);`
`16880`	`16881`	`if (!GetConsoleMode(handle, &mode)) {`
`16881`	`16882`	`Py_RETURN_FALSE;`
`16882`	`16883`	`}`
`16883`	`16884`	`return PyBool_FromLong(mode & ENABLE_VIRTUAL_TERMINAL_PROCESSING);`
	`16885`	`+#else`
	`16886`	`+ Py_RETURN_FALSE;`
	`16887`	`+#endif /* HAVE_WINDOWS_CONSOLE_IO */`
`16884`	`16888`	`}`
`16885`	`16889`	`#endif`
`16886`	`16890`