[3.12] gh-122332: Fix missing NULL check in asyncio.Task.get_coro (GH-122338) (#122345)

miss-islington · ZeroIntensity · web-flow · commit 102dc44a0afe · 2024-07-27T12:36:40.000+05:30
gh-122332: Fix missing `NULL` check in `asyncio.Task.get_coro` (GH-122338) (cherry picked from commit c086962) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
diff --git a/Lib/test/test_asyncio/test_eager_task_factory.py b/Lib/test/test_asyncio/test_eager_task_factory.py
@@ -246,6 +246,18 @@ class DummyLoop:
         _, out, err = assert_python_ok("-c", code)
         self.assertFalse(err)
 
+    def test_issue122332(self):
+       async def coro():
+           pass
+
+       async def run():
+           task = self.loop.create_task(coro())
+           await task
+           self.assertIsNone(task.get_coro())
+
+       self.run_coro(run())
+
+
 class AsyncTaskCounter:
     def __init__(self, loop, *, task_class, eager):
         self.suspense_count = 0
diff --git a/Misc/NEWS.d/next/Library/2024-07-26-21-21-13.gh-issue-122332.fvw88r.rst b/Misc/NEWS.d/next/Library/2024-07-26-21-21-13.gh-issue-122332.fvw88r.rst
@@ -0,0 +1,2 @@
+Fixed segfault with :meth:`asyncio.Task.get_coro` when using an eager task
+factory.
diff --git a/Modules/_asynciomodule.c b/Modules/_asynciomodule.c
@@ -2509,7 +2509,11 @@ static PyObject *
 _asyncio_Task_get_coro_impl(TaskObj *self)
 /*[clinic end generated code: output=bcac27c8cc6c8073 input=d2e8606c42a7b403]*/
 {
-    return Py_NewRef(self->task_coro);
+    if (self->task_coro) {
+        return Py_NewRef(self->task_coro);
+    }
+
+    Py_RETURN_NONE;
 }
 
 /*[clinic input]

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Fixed segfault with :meth:`asyncio.Task.get_coro` when using an eager task
	`2`	`+factory.`
Original file line number	Diff line number	Diff line change
`@@ -2509,7 +2509,11 @@ static PyObject *`
`2509`	`2509`	`_asyncio_Task_get_coro_impl(TaskObj *self)`
`2510`	`2510`	`/[clinic end generated code: output=bcac27c8cc6c8073 input=d2e8606c42a7b403]/`
`2511`	`2511`	`{`
`2512`		`- return Py_NewRef(self->task_coro);`
	`2512`	`+ if (self->task_coro) {`
	`2513`	`+ return Py_NewRef(self->task_coro);`
	`2514`	`+ }`
	`2515`	`+`
	`2516`	`+ Py_RETURN_NONE;`
`2513`	`2517`	`}`
`2514`	`2518`
`2515`	`2519`	`/*[clinic input]`