Fix test_long_loop() (sort of)

gvanrossum · gvanrossum · commit 0caa9f9d9e3e · 2023-11-29T10:16:57.000+09:00
diff --git a/Lib/test/test_capi/test_misc.py b/Lib/test/test_capi/test_misc.py
@@ -2411,14 +2411,20 @@ def loop():
                 self.assertEqual(opt.get_count(), 1000)
 
     def test_long_loop(self):
-        "Check that we aren't confused by EXTENDED_ARG"
+        # Check that we aren't confused by EXTENDED_ARG
 
         # Generate a new function at each call
         ns = {}
         exec(textwrap.dedent("""
             def nop():
                 pass
 
+            def short_loop():
+                for _ in range(10):
+                    nop(); nop(); nop(); nop(); nop(); nop(); nop(); nop();
+                    nop(); nop(); nop(); nop(); nop(); nop(); nop(); nop();
+                    nop(); nop(); nop(); nop(); nop(); nop(); nop(); nop();
+
             def long_loop():
                 for _ in range(10):
                     nop(); nop(); nop(); nop(); nop(); nop(); nop(); nop();
@@ -2429,14 +2435,21 @@ def long_loop():
                     nop(); nop(); nop(); nop(); nop(); nop(); nop(); nop();
                     nop(); nop(); nop(); nop(); nop(); nop(); nop(); nop();
         """), ns, ns)
+        short_loop = ns['short_loop']
         long_loop = ns['long_loop']
 
         opt = _testinternalcapi.get_counter_optimizer()
         with temporary_optimizer(opt):
             self.assertEqual(opt.get_count(), 0)
-            long_loop()
+            short_loop()
             self.assertEqual(opt.get_count(), 10)
 
+        opt = _testinternalcapi.get_counter_optimizer()
+        with temporary_optimizer(opt):
+            self.assertEqual(opt.get_count(), 0)
+            long_loop()  # Should not optimize!
+            self.assertEqual(opt.get_count(), 0)
+
     def test_code_restore_for_ENTER_EXECUTOR(self):
         def testfunc(x):
             i = 0
