bpo-45851: Avoid full sort in statistics.multimode() (#29662)

rhettinger · web-flow · commit 04e03f496cf7 · 2021-11-20T10:04:37.000-06:00
Suggested by Stefan Pochmann.
diff --git a/Lib/statistics.py b/Lib/statistics.py
@@ -609,9 +609,11 @@ def multimode(data):
     >>> multimode('')
     []
     """
-    counts = Counter(iter(data)).most_common()
-    maxcount, mode_items = next(groupby(counts, key=itemgetter(1)), (0, []))
-    return list(map(itemgetter(0), mode_items))
+    counts = Counter(iter(data))
+    if not counts:
+        return []
+    maxcount = max(counts.values())
+    return [value for value, count in counts.items() if count == maxcount]
 
 
 # Notes on methods for computing quantiles
