Remove usesless function from csv module (GH-20762)

corona10 · web-flow · commit 0383be466690 · 2020-06-10T00:33:43.000+09:00
diff --git a/Modules/_csv.c b/Modules/_csv.c
@@ -146,13 +146,6 @@ get_dialect_from_registry(PyObject * name_obj)
     return dialect_obj;
 }
 
-static PyObject *
-get_string(PyObject *str)
-{
-    Py_XINCREF(str);
-    return str;
-}
-
 static PyObject *
 get_nullchar_as_None(Py_UCS4 c)
 {
@@ -166,7 +159,8 @@ get_nullchar_as_None(Py_UCS4 c)
 static PyObject *
 Dialect_get_lineterminator(DialectObj *self, void *Py_UNUSED(ignored))
 {
-    return get_string(self->lineterminator);
+    Py_XINCREF(self->lineterminator);
+    return self->lineterminator;
 }
 
 static PyObject *

Original file line number	Diff line number	Diff line change
`@@ -146,13 +146,6 @@ get_dialect_from_registry(PyObject * name_obj)`
`146`	`146`	`return dialect_obj;`
`147`	`147`	`}`
`148`	`148`
`149`		`-static PyObject *`
`150`		`-get_string(PyObject *str)`
`151`		`-{`
`152`		`- Py_XINCREF(str);`
`153`		`- return str;`
`154`		`-}`
`155`		`-`
`156`	`149`	`static PyObject *`
`157`	`150`	`get_nullchar_as_None(Py_UCS4 c)`
`158`	`151`	`{`
`@@ -166,7 +159,8 @@ get_nullchar_as_None(Py_UCS4 c)`
`166`	`159`	`static PyObject *`
`167`	`160`	`Dialect_get_lineterminator(DialectObj self, void Py_UNUSED(ignored))`
`168`	`161`	`{`
`169`		`- return get_string(self->lineterminator);`
	`162`	`+ Py_XINCREF(self->lineterminator);`
	`163`	`+ return self->lineterminator;`
`170`	`164`	`}`
`171`	`165`
`172`	`166`	`static PyObject *`