dict: Remove redundant incref of immortal object Py_EMPTY_KEYS (GH-133200)

biglizards · web-flow · commit 011979132648 · 2025-05-01T08:39:26.000+09:00
diff --git a/Objects/dictobject.c b/Objects/dictobject.c
@@ -4851,7 +4851,8 @@ dict_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
 
     d->ma_used = 0;
     d->_ma_watcher_tag = 0;
-    dictkeys_incref(Py_EMPTY_KEYS);
+    // We don't inc ref empty keys because they're immortal
+    assert((Py_EMPTY_KEYS)->dk_refcnt == _Py_DICT_IMMORTAL_INITIAL_REFCNT);
     d->ma_keys = Py_EMPTY_KEYS;
     d->ma_values = NULL;
     ASSERT_CONSISTENT(d);
