8000 Replace `gh-issue-NNNN:` with `gh-NNNN:` in the output by ezio-melotti · Pull Request #451 · python/core-workflow · GitHub
[go: up one dir, main page]

Skip to content

Replace gh-issue-NNNN: with gh-NNNN: in the output #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

ezio-melotti
Copy link
Member

I noticed in python/cpython#92448 that the output shows gh-issues-NNNN: instead of gh-NNNN:. I had initially proposed to use gh-issue instead of just issue in the content of the entry because in that case is ambiguous and people might have added the bpo number. In the output there is no such problem, and gh-NNNN is enough.

AFAIU if this PR is applied, it will update older news entries too, right?

Copy link
@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Does this also need a doc update?

@ezio-melotti
Copy link
Member Author

Which docs do you mean?

@erlend-aasland
Copy link

Which docs do you mean?

I should have phrased myself clearer :) If there are any docs that mention this, they would need an update.

@ezio-melotti ezio-melotti merged commit eac97e4 into master Jul 14, 2022
@ezio-melotti ezio-melotti deleted the gh-in-output branch July 14, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0