8000 gh-419: Allow unstable builders to trigger on PRs by itamaro · Pull Request #420 · python/buildmaster-config · GitHub
[go: up one dir, main page]
Skip to content

gh-419: Allow unstable builders to trigger on PRs #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2023
Merged

gh-419: Allow unstable builders to trigger on PRs #420

merged 3 commits into from
Oct 27, 2023

Conversation

itamaro
Copy link
Contributor
@itamaro itamaro commented Oct 8, 2023 •
edited
Loading

This intention of this PR is to make it possible to manually trigger also unstable buildbots on PRs using the !buildbot command (and labels).

The lists of "PR builders" are used in several places where I kept it to only stable PR builders, because those other places didn't seem related to the manual triggering of buildbots on PRs.

@itamaro
pythongh-419: Allow unstable builders to trigger on PRs
7ed53bd 
This intention of this PR is to make it possible to *manually trigger* also unstable buildbots on PRs using the `!buildbot` command (and labels).

The lists of "PR builders" are used in several places where I kept it to *only* stable PRs, because those other places didn't seem related to the manual triggering of buildbots on PRs.
@itamaro itamaro mentioned this pull request Oct 8, 2023
Closed
@itamaro itamaro requested review from ambv and vstinner October 8, 2023 22:05
vstinner
vstinner reviewed Oct 13, 2023
View reviewed changes
@colesbury
Copy link
Contributor
colesbury commented Oct 16, 2023 •
edited
Loading

I would really like to see this change land, not only for the nogil buildbots but also so I can test changes on AIX. The AIX buildbots are also marked as "unstable".

@itamaro
Copy link
Contributor Author
itamaro commented Oct 18, 2023

@vstinner I am not sure how to test changes like this manually / locally, as it seems highly coupled with the details of the actual deployed buildbot master.

I think we do want to allow using a PR !buildbot ... comment to match unstable builders, but using the test-with-buildbots or test-with-refleak-buildbots labels should trigger only stable builders.

both PR labels and comments are handled in CustomGitHubEventHandler, but it appears that the builder_names argument is only used when doing matching against a PR comment. in case of a PR label, I don't see how exactly the builder names are plumbed through, and it isn't clear to me whether this change would impact the behavior of the label-based triggering, or only the comment-based triggering.

@ambv ambv merged commit 24242c7 into python:main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@ambv ambv Awaiting requested review from ambv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itamaro @colesbury @vstinner @ambv
0