8000 Disable Windows 7 on the Python 3.x branch · Issue #168 · python/buildmaster-config · GitHub
[go: up one dir, main page]
Skip to content

Disable Windows 7 on the Python 3.x branch #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vstinner opened this issue Feb 18, 2020 · 7 comments
Closed

Disable Windows 7 on the Python 3.x branch #168

vstinner opened this issue Feb 18, 2020 · 7 comments

Comments

@vstinner
Copy link
Member

Can someone try to propose a PR on https://github.com/python/buildmaster-config/blob/master/master/custom/builders.py to remove Windows 7 from stable buildbots? That would remove them from stable on all Python branches.

The other option would be to hack https://github.com/python/buildmaster-config/blob/master/master/custom/workers.py to exclude 3.x branch from Windows 7 workers.

The last option is to hack https://github.com/python/buildmaster-config/blob/master/master/master.cfg to add a special rule to not schedule jobs on the 3.x branch if "win7" flag is present.

I'm not sure which approach is the best. Maybe @zware or @pablogsal have an opinion on that :-)
@aeros
Copy link
aeros commented Mar 14, 2020 •
edited
Loading

In builders.py, it seems that the Windows XP builders are still present as well. Could we also remove those from the stable builders since XP is no longer supported by Microsoft?

See:

buildmaster-config/master/custom/builders.py

Lines 104 to 112 in d87219b

# Windows
("AMD64 Windows7 SP1", "kloth-win64", Windows64Build, STABLE),
("AMD64 Windows7 SP1 VS9.0", "kloth-win64", Windows6427VS9Build, STABLE),
("AMD64 Windows10", "bolen-windows10", Windows64Build, STABLE),
("AMD64 Windows8.1 Non-Debug", "ware-win81-release", Windows64ReleaseBuild, STABLE),
("AMD64 Windows8.1 Refleaks", "ware-win81-release", Windows64RefleakBuild, STABLE),
("x86 Windows7", "bolen-windows7", SlowWindowsBuild, STABLE),
("x86 Windows XP", "bolen-windows", WindowsBuild, STABLE),
("x86 Windows XP VS9.0", "bolen-windows", Windows27VS9Build, STABLE),

@zware
Copy link
Member
zware commented Mar 14, 2020

We'll remove the XP worker and builders when we remove the 2.7 builders.

@aeros aeros mentioned this issue Mar 14, 2020
Closed
@aeros
Copy link
aeros commented Mar 14, 2020

Oh okay, I'll adjust the PR then.

@aeros
Copy link
aeros commented Mar 15, 2020

It was recently brought to my attention that this issue was already addressed by @vstinner in #171, so I'll close the issue. If there's something that still needs to be addressed, feel free to reopen it.

@aeros aeros closed this as completed Mar 15, 2020
@vstinner
Copy link
Member Author

Windows XP is only used to test Python 2.7. See master.cfg:

        if "Windows XP" in name and branchname != "2.7":
            # 3.5+ drop support for XP
            continue

@aeros
Copy link
aeros commented Mar 25, 2020 •
edited
Loading

@vstinner Was the intention to also disable Windows 7 when using the recently added test-with-buildbots label in PRs to 3.x? If so, I just saw a couple of Windows 7 buildbots present when I used it in python/cpython#19149 (AMD64 Windows7 SP1 PR and x86 Windows7 PR).

@vstinner
Copy link
Member Author

@vstinner Was the intention to also disable Windows 7 when using the recently added test-with-buildbots label in PRs to 3.x? If so, I just saw a couple of Windows 7 buildbots present when I used it in python/cpython#19149 (AMD64 Windows7 SP1 PR and x86 Windows7 PR).

I proposed #176 to fix that.

vstinner added a commit that referenced this issue Mar 25, 2020
@vstinner
Merge pull request #176 from vstinner/drop_win7_pr
a079e54 
GH
4CD5
-168: Drop Windows7 PR workers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vstinner @zware @aeros
0