Python issue #23347: Make BaseSubprocessTransport.wait() private

vstinner · vstinner · commit d37a906ecc49 · 2015-01-30T00:15:54.000+01:00
diff --git a/asyncio/base_subprocess.py b/asyncio/base_subprocess.py
@@ -208,7 +208,7 @@ def _process_exited(self, returncode):
                 waiter.set_result(returncode)
         self._exit_waiters = None
 
-    def wait(self):
+    def _wait(self):
         """Wait until the process exit and return the process return code.
 
         This method is a coroutine."""
diff --git a/asyncio/subprocess.py b/asyncio/subprocess.py
@@ -115,7 +115,7 @@ def wait(self):
         """Wait until the process exit and return the process return code.
 
         This method is a coroutine."""
-        return (yield from self._transport.wait())
+        return (yield from self._transport._wait())
 
     def send_signal(self, signal):
         self._transport.send_signal(signal)
diff --git a/asyncio/unix_events.py b/asyncio/unix_events.py
@@ -188,7 +188,7 @@ def _make_subprocess_transport(self, protocol, args, shell,
                 yield from waiter
             except:
                 transp.close()
-                yield from transp.wait()
+                yield from transp._wait()
                 raise
 
         return transp
diff --git a/asyncio/windows_events.py b/asyncio/windows_events.py
@@ -375,7 +375,7 @@ def _make_subprocess_transport(self, protocol, args, shell,
             yield from waiter
         except:
             transp.close()
-            yield from transp.wait()
+            yield from transp._wait()
             raise
 
         return transp

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ def wait(self):`
`115`	`115`	`"""Wait until the process exit and return the process return code.`
`116`	`116`
`117`	`117`	`This method is a coroutine."""`
`118`		`- return (yield from self._transport.wait())`
	`118`	`+ return (yield from self._transport._wait())`
`119`	`119`
`120`	`120`	`def send_signal(self, signal):`
`121`	`121`	`self._transport.send_signal(signal)`