Updating polyscript to its latest #2128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30d99b2 to
4a08e77
Compare
|
@mchilvers FYI all issues around SAB and named workers are automatically resolved by this latest version. I have decided to use a |
54c89a6 to
fc1750f
Compare
e8f77d2 to
28bc219
Compare
for more information, see https://pre-commit.ci
28bc219 to
b5a1161
Compare
e4e1c82 to
f2dd278
Compare
ntoll
approved these changes
Jul 29, 2024
fba54f5 to
5133022
Compare
for more information, see https://pre-commit.ci
838bb1a to
1ade26c
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently published as
0.5.0-rc4on npm:https://cdn.jsdelivr.net/npm/@pyscript/core@next/dist/core.jshttps://cdn.jsdelivr.net/npm/@pyscript/core@next/dist/core.cssDocumentation
pyscript/docs#134
Summary
The latest coincident is being tested to provide the following features:
serviceWorkerorservice_workerurl is passed as options / config, it eventually does fallback to sync XHR based exchanges that makes it still possible to usewindowordocumentfrom workers, even if headers required to enabled native SharedArrayBuffer are nowhere in the project, thanks to sabayon helperThe current
polyscript@nextalso has been improved to both use latest coincident and simplify the bootstrap logic, providing better ways to also understand whenwindowordocumentcannot be used, printing better / more meaningful errors too.The concept here is that as long as you don't try to use
windowordocument, you don't need to care about SharedArrayBuffer so that general DX should hopefully be better now.Literally nothing that was working before should break now, quite the opposite, it should be eventually slightly faster with more fine-tuned memory leaks prevention thanks to underlying libraries updates and the communication channel between multiple workers have been improved too.