8000 Investigate greedy GC breaking some test · Issue #2185 · pyscript/pyscript · GitHub
[go: up one dir, main page]

Skip to content
Investigate greedy GC breaking some test #2185
Closed
@WebReflection

Description

@WebReflection

What happened?

After latest tests update and latest playwright module landed, we've seen sketchy results and it looks like coincident receives GC calls to free local references even if these are used later on in the program.

A polyscript change was required to fix one test but now there's another test failing mostly only with playwright, although I can reproduce the issue via rage-clicking GC button in the performance devtools' panel to see the error myself, which is half good-news (I have a way to investigate that).

Although workers / main dance is fully orchestrated via numbers and it's not really easy to debug/understand what's going on, meaning:

  • I should likely improve coincident debug-ability with way more descriptive logs
  • I should likely avoid smart cached references in polyscript that might result into early GC calls for no reason
  • I should be sure our tests are never flaky and check that in PyScript we don't also cause issues with greedy GC operations

This is probably just a placeholder to allow MR to update various libraries but I think it has top priority, although it is not nearly as easy as it sounds to be fixed ... let's hope I manage in a way that is robust and surprises-less.

What browsers are you seeing the problem on? (if applicable)

No response

Console info

No response

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0