8000 [Worker support] Fix py-repl · Issue #1383 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content
8000

[Worker support] Fix py-repl #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
antocuni opened this issue Apr 12, 2023 · 1 comment
Closed

[Worker support] Fix py-repl #1383

antocuni opened this issue Apr 12, 2023 · 1 comment
Labels
classic Issues only applicable to PyScript versions 2023.05.1 and earlier ("PyScript Classic")

Comments

@antocuni
Copy link
Contributor

This is a follow-up of #1333 (once it's merged).
test_py_repl contains 15 tests which are skipped in workers:

82:    @skip_worker("FIXME: display()")
83-    def test_display(self):
--
96:    @skip_worker("TIMEOUT")
97-    def test_show_last_expression(self):
--
114:    @skip_worker("TIMEOUT")
115-    def test_show_last_expression_with_output(self):
--
136:    @skip_worker("FIXME: display()")
137-    def test_run_clears_previous_output(self):
--
187:    @skip_worker("FIXME: display()")
188-    def test_multiple_repls(self):
--
210:    @skip_worker("FIXME: display()")
211-    def test_python_exception_after_previous_output(self):
--
232:    @skip_worker("FIXME: js.document")
233-    def test_hide_previous_error_after_successful_run(self):
--
280:    @skip_worker("TIMEOUT")
281-    def test_auto_generate(self):
--
311:    @skip_worker("FIXME: display()")
312-    def test_multiple_repls_mixed_display_order(self):
--
343:    @skip_worker("FIXME: display()")
344-    def test_repl_output_attribute(self):
--
369:    @skip_worker("FIXME: js.document")
370-    def test_repl_output_display_async(self):
--
410:    @skip_worker("FIXME: js.document")
411-    def test_repl_stdio_dynamic_tags(self):
--
513:    @skip_worker("TIMEOUT")
514-    def test_repl_output_attribute_change(self):
--
551:    @skip_worker("TIMEOUT")
552-    def test_repl_output_element_id_change(self):
--
607:    @skip_worker("TIMEOUT")
608-    def test_repl_src_change(self):

Some are marked as FIXME: js.document and FIXME: display(), so they should be automatically solved by #1379 and #1380, but others are timeouts which should be investigated
@antocuni antocuni mentioned this issue Apr 12, 2023
Closed
@JeffersGlass JeffersGlass added the classic Issues only applicable to PyScript versions 2023.05.1 and earlier ("PyScript Classic") label Sep 15, 2023
@WebReflection
Copy link
Contributor

This issue is labeled for classic but the worker story in there is ... gone? I think we should close this also because we don't have a py-repl in next, just terminal and editor so far. We might write a new issue once we'll have, if ever, a repl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
classic Issues only applicable to PyScript versions 2023.05.1 and earlier ("PyScript Classic")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WebReflection @antocuni @JeffersGlass
0