8000 [Worker support] Fix plugins · Issue #1382 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

[Worker support] Fix plugins #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
antocuni opened this issue Apr 12, 2023 · 1 comment
Closed

[Worker support] Fix plugins #1382

antocuni opened this issue Apr 12, 2023 · 1 comment
Labels
classic Issues only applicable to PyScript versions 2023.05.1 and earlier ("PyScript Classic")

Comments

@antocuni
Copy link
Contributor

This is a follow-up of #1333 (once it's merged).

Plugins are completely broken. test_plugins.py contains 6 skipped tests, for example:

pyscript/pyscriptjs/tests/integration/test_plugins.py

Lines 196 to 199 in ef0e838

class TestPlugin(PyScriptTest):
@skip_worker("FIXME: relative paths")
@prepare_test("py-upper", CE_PLUGIN_CODE, tagname="py-up", html="Hello World")
def test_py_plugin_inline(self):

Complete list:

197:    @skip_worker("FIXME: relative paths")
198-    @prepare_test("py-upper", CE_PLUGIN_CODE, tagname="py-up", html="Hello World")
--
213:    @skip_worker("FIXME: relative paths")
214-    @prepare_test("hooks_logger", HOOKS_PLUGIN_CODE, template=HTML_TEMPLATE_NO_TAG)
--
246:    @skip_worker("FIXME: relative paths")
247-    @prepare_test(
--
269:    @skip_worker("FIXME: relative paths")
270-    @prepare_test(
--
294:    @skip_worker("FIXME: relative paths")
295-    @prepare_test("no_plugin", NO_PLUGIN_CODE)
--
309:    @skip_worker("FIXME: relative paths")
310-    def test_fetch_python_plugin(self):
@antocuni antocuni mentioned this issue Apr 12, 2023
Closed
@JeffersGlass JeffersGlass added the classic Issues only applicable to PyScript versions 2023.05.1 and earlier ("PyScript Classic") label Sep 15, 2023
@WebReflection
Copy link
Contributor

We have plugins for both main and workers and the story is a bit different now as it's all about core hooks and main/worker bootstrap but also we have extra integration tests to check everything is fine. Closing as this looks not relevant anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
classic Issues only applicable to PyScript versions 2023.05.1 and earlier ("PyScript Classic")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WebReflection @antocuni @JeffersGlass
0