8000 [Worker support] Add a test for missing CORS headers · Issue #1312 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

[Worker support] Add a test for missing CORS headers #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
antocuni opened this issue Mar 27, 2023 · 0 comments · Fixed by #1374
Closed

[Worker support] Add a test for missing CORS headers #1312

antocuni opened this issue Mar 27, 2023 · 0 comments · Fixed by #1374
Assignees
@madhur-tandon

Comments

@antocuni
Copy link
Contributor
antocuni commented Mar 27, 2023 •
edited
Loading

This is a follow-up of #1258.
The original discussion is here: https://github.com/pyscript/pyscript/pull/1258/files#r1146261682

After the introduction of synclink, we require the CORS headers to be set.

We should introduce a test which checks that happens if the web server doesn't set them, and display a nice and error message (ideally with a link to a detailed page in our documentation) to explain what's the problem.

EDIT

it turns out that on main the CORS headers are not required at all, so there is no point in testing them. But they will be required in the worker case as soon as #1333 is merged, so I rebranded this issue as [Worker support] and made it became a follow-up of #1333 .
@antocuni antocuni mentioned this issue Mar 27, 2023
Merged
@madhur-tandon madhur-tandon mentioned this issue Apr 10, 2023
Merged
@antocuni antocuni changed the title Add a test for missing CORS headers [Worker support] Add a test for missing CORS headers Apr 13, 2023
@antocuni antocuni mentioned this issue Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madhur-tandon madhur-tandon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Worker support] test for no cors headers madhur-tandon/pyscript
2 participants
@antocuni @madhur-tandon
0