Potential double free

KaloNK · web-flow · commit 9a7d4f2e2d19 · 2021-12-12T21:00:36.000+02:00
diff --git a/src/HTTPSConnection.cpp b/src/HTTPSConnection.cpp
@@ -13,6 +13,14 @@ HTTPSConnection::HTTPSConnection(ResourceResolver * resResolver):
 HTTPSConnection::~HTTPSConnection() {
   // Close the socket
   closeConnection();
+#ifdef HTTPS_USE_MBEDTLS
+  freeSSL();
+}
+
+void HTTPSConnection::freeSSL() {
+  mbedtls_ssl_free( &_ssl );
+  mbedtls_net_free( &_client_fd );
+#endif
 }
 
 bool HTTPSConnection::isSecure() {
@@ -77,7 +85,6 @@ int HTTPSConnection::initialize(mbedtls_net_context * server_fd, mbedtls_ssl_con
         }
 
         mbedtls_ssl_session_reset( &_ssl );
-        mbedtls_net_free( &_client_fd );
       }
     }
 #ifdef MBEDTLS_ERROR_C

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,14 @@ HTTPSConnection::HTTPSConnection(ResourceResolver * resResolver):`
`13`	`13`	`HTTPSConnection::~HTTPSConnection() {`
`14`	`14`	`// Close the socket`
`15`	`15`	`closeConnection();`
	`16`	`+#ifdef HTTPS_USE_MBEDTLS`
	`17`	`+ freeSSL();`
	`18`	`+}`
	`19`	`+`
	`20`	`+void HTTPSConnection::freeSSL() {`
	`21`	`+ mbedtls_ssl_free( &_ssl );`
	`22`	`+ mbedtls_net_free( &_client_fd );`
	`23`	`+#endif`
`16`	`24`	`}`
`17`	`25`
`18`	`26`	`bool HTTPSConnection::isSecure() {`
`@@ -77,7 +85,6 @@ int HTTPSConnection::initialize(mbedtls_net_context * server_fd, mbedtls_ssl_con`
`77`	`85`	`}`
`78`	`86`
`79`	`87`	`mbedtls_ssl_session_reset( &_ssl );`
`80`		`- mbedtls_net_free( &_client_fd );`
`81`	`88`	`}`
`82`	`89`	`}`
`83`	`90`	`#ifdef MBEDTLS_ERROR_C`