8000 Update documentation for rotaryio.IncrementalEncoder · pypewpew/circuitpython@fd4a612 · GitHub
[go: up one dir, main page]

Skip to content

Commit fd4a612

Browse files
committed
Update documentation for rotaryio.IncrementalEncoder
Update the documentation in circuitpython/shared-bindings/rotaryio/IncrementalEncoder.c to explicitly state that rotaryio.IncrementalEncoder assumes the encoder's pins are connected to ground and sets pull-ups on the pins accordingly. Closes adafruit#5847 Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
1 parent ed4d4a6 commit fd4a612

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

shared-bindings/rotaryio/IncrementalEncoder.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@
3535
#include "shared-bindings/util.h"
3636

3737
//| class IncrementalEncoder:
38-
//| """IncrementalEncoder determines the relative rotational position based on two series of pulses."""
38+
//| """IncrementalEncoder determines the relative rotational position based on two series of pulses.
39+
//| It assumes that the encoder's common pin(s) are connected to ground,and enables pull-ups on
40+
//| pin_a and pin_b."""
3941
//|
4042
//| def __init__(
4143
//| self, pin_a: microcontroller.Pin, pin_b: microcontroller.Pin, divisor: int = 4

0 commit comments

Comments
 (0)
0