Description
Environment
- pip version: 20.1
- Python version: 3.8.1
- OS: ubuntu 18.04 (xenial)
Description
After a pip install with umask set to 027, files in the environment have incorrect permissions.
I expected the files to have permissions 640, but they ended up as 637. This is both too restrictive at the group level and too permissive at the world level.
Expected behavior
Correct file permissions.
I think the cause is this fix:
https://github.com/pypa/pip/pull/8144/files#diff-81eaeaa2196a8c5382958f2d9f22b593R570
generated_file_mode = 0o666 - current_umask()
>>> oct(0o666 - 0o027)
'0637'
I'd have expected a bitwise AND so the result would be 0640.
How to Reproduce
virtualenv ./env
source env/bin/activate
umask 027
pip install six
ls -lR env/lib/python3.8/site-packages/six-1.14.0.dist-info/
Output
root@674aabd90334:~# virtualenv ./env
Using base prefix '/opt/Python/3.8.1'
New python executable in /root/env/bin/python3.8
copying /opt/Python/3.8.1/bin/python3.8 => /root/env/bin/python3.8
Also creating executable in /root/env/bin/python
Installing setuptools, pip, wheel...
done.
root@674aabd90334:~# source env/bin/activate
(env) root@674aabd90334:~# umask 027
(env) root@674aabd90334:~# pip install six
Collecting six
Using cached six-1.14.0-py2.py3-none-any.whl (10 kB)
Installing collected packages: six
Successfully installed six-1.14.0
(env) root@674aabd90334:~# ls -lR env/lib/python3.8/site-packages/six-1.14.0.dist-info/
env/lib/python3.8/site-packages/six-1.14.0.dist-info/:
total 24
-rw--wxrwx 1 root root 4 Apr 28 21:13 INSTALLER
-rw-r----- 1 root root 1066 Apr 28 21:13 LICENSE
-rw-r----- 1 root root 1795 Apr 28 21:13 METADATA
-rw--wxrwx 1 root root 560 Apr 28 21:13 RECORD
-rw-r----- 1 root root 110 Apr 28 21:13 WHEEL
-rw-r----- 1 root root 4 Apr 28 21:13 top_level.txt
4906