8000 code review suggestions · pygame/python-for-android@bd68502 · GitHub
[go: up one dir, main page]

Skip to content

Commit bd68502

Browse files
author
Robert Pfeiffer
committed
code review suggestions
1 parent 975162e commit bd68502

File tree

2 files changed

+21
-30
lines changed

2 files changed

+21
-30
lines changed

pythonforandroid/bootstraps/common/build/build.py

Lines changed: 12 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -86,17 +86,10 @@ def get_bootstrap_name():
8686
environment = jinja2.Environment(loader=jinja2.FileSystemLoader(
8787
join(curdir, 'templates')))
8888

89-
90-
def try_unlink(fn):
91-
if exists(fn):
92-
os.unlink(fn)
93-
94-
9589
def ensure_dir(path):
9690
if not exists(path):
9791
makedirs(path)
9892

99-
10093
def render(template, dest, **kwargs):
10194
'''Using jinja2, render `template` to the filename `dest`, supplying the
10295
@@ -239,10 +232,8 @@ def make_package(args):
239232
assets_dir = "src/main/assets"
240233

241234
# Delete the old assets.
242-
if os.path.exists(assets_dir):
243-
shutil.rmtree(assets_dir)
235+
shutil.rmtree(assets_dir, ignore_errors=True)
244236
ensure_dir(assets_dir)
245-
open(os.path.join(assets_dir, ".gitkeep"), 'a').close()
246237

247238
# Add extra environment variable file into tar-able directory:
248239
env_vars_tarpath = tempfile.mkdtemp(prefix="p4a-extra-env-")
@@ -305,14 +296,14 @@ def make_package(args):
305296
tar_dirs.append(python_bundle_dir)
306297
if get_bootstrap_name() == "webview":
307298
tar_dirs.append('webview_includes')
308-
if hasattr(args, "assets") and args.assets is not None:
309-
for asset in args.assets:
310-
asset_src, asset_dest = asset.split(":")
311-
if isfile(realpath(asset_src)):
312-
ensure_dir(dirname(join(assets_dir, asset_dest)))
313-
shutil.copy(realpath(asset_src), join(assets_dir, asset_dest))
314-
else:
315-
shutil.copytree(realpath(asset_src), join(assets_dir, asset_dest))
299+
300+
for asset in args.assets:
301+
asset_src, asset_dest = asset.split(":")
302+
if isfile(realpath(asset_src)):
303+
ensure_dir(dirname(join(assets_dir, asset_dest)))
304+
shutil.copy(realpath(asset_src), join(assets_dir, asset_dest))
305+
else:
306+
shutil.copytree(realpath(asset_src), join(assets_dir, asset_dest))
316307

317308
if args.private or args.launcher:
318309
make_tar(
@@ -609,8 +600,9 @@ def parse_args_and_make_package(args=None):
609600
ap.add_argument('--uses-library', dest='android_used_libs', action='append', default=[],
610601
help='Used shared libraries included using <uses-library> tag in AndroidManifest.xml')
611602
ap.add_argument('--asset', dest='assets',
612-
action="append",
613-
help=('Put this in the assets folder'))
603+
action="append", default=[],
604+
metavar="/path/to/source:dest"
605+
help='Put this in the assets folder at assets/dest')
614606
ap.add_argument('--icon', dest='icon',
615607
help=('A png file to use as the icon for '
616608
'the application.'))

pythonforandroid/toolchain.py

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -496,8 +496,8 @@ def add_parser(subparsers, *args, **kwargs):
496496
# is why we also add it here:
497497
parser_apk.add_argument(
498498
'--add-asset', dest='assets',
499-
action="append",
500-
help=('Put this in the assets folder'))
499+
action="append", default=[],
500+
help='Put this in the assets folder in the apk.')
501501
parser_apk.add_argument(
502502
'--private', dest='private',
503503
help='the directory with the app source code files' +
@@ -586,14 +586,13 @@ def add_parser(subparsers, *args, **kwargs):
586586
args.unknown_args += ["--private", args.private]
587587
if hasattr(args, "build_mode") and args.build_mode == "release":
588588
args.unknown_args += ["--release"]
589-
if hasattr(args, "assets") and args.assets is not None:
590-
# Pass this value on to the internal bootstrap build.py:
591-
for asset in args.assets:
592-
if ":" in asset:
593-
asset_src, asset_dest = asset.split(":")
594-
else:
595-
asset_src = asset_dest = asset
596-
args.unknown_args += ["--asset", os.path.abspath(asset_src)+":"+asset_dest]
589+
for asset in args.assets:
590+
if ":" in asset:
591+
asset_src, asset_dest = asset.split(":")
592+
else:
593+
asset_src = asset_dest = asset
594+
# take abspath now, because build.py will be run in bootstrap dir
595+
args.unknown_args += ["--asset", os.path.abspath(asset_src)+":"+asset_dest]
597596
if hasattr(args, "ignore_setup_py") and args.ignore_setup_py:
598597
args.use_setup_py = False
599598

0 commit comments

Comments
 (0)
0