10000 [skip-ci] Fix benchmark CI · pydata/xarray@e2f7d88 · GitHub
[go: up one dir, main page]

Skip to content

Commit e2f7d88

Browse files
committed
[skip-ci] Fix benchmark CI
1 parent 4e9d557 commit e2f7d88

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

.github/workflows/benchmarks.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,11 @@ jobs:
2828
environment-name: xarray-tests
2929
cache-environment: true
3030
cache-environment-key: "${{runner.os}}-${{runner.arch}}-py${{env.PYTHON_VERSION}}-${{env.TODAY}}-${{hashFiles(env.CONDA_ENV_FILE)}}-benchmark"
31+
# add "build" because of https://github.com/airspeed-velocity/asv/issues/1385
3132
create-args: >-
3233
asv
34+
build
35+
mamba
3336
3437
3538
- name: Run benchmarks
@@ -47,9 +50,6 @@ jobs:
4750
asv machine --yes
4851
echo "Baseline: ${{ github.event.pull_request.base.sha }} (${{ github.event.pull_request.base.label }})"
4952
echo "Contender: ${GITHUB_SHA} (${{ github.event.pull_request.head.label }})"
50-
# Use mamba for env creation
51-
# export CONDA_EXE=$(which mamba)
52-
export CONDA_EXE=$(which conda)
5353
# Run benchmarks for current commit against base
5454
ASV_OPTIONS="--split --show-stderr --factor $ASV_FACTOR"
5555
asv continuous $ASV_OPTIONS ${{ github.event.pull_request.base.sha }} ${GITHUB_SHA} \

asv_bench/asv.conf.json

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
// If missing or the empty string, the tool will be automatically
3030
// determined by looking for tools on the PATH environment
3131
// variable.
32-
"environment_type": "conda",
32+
"environment_type": "mamba",
3333
"conda_channels": ["conda-forge"],
3434

3535
// timeout in seconds for installing any dependencies in environment
@@ -41,7 +41,7 @@
4141

4242
// The Pythons you'd like to test against. If not provided, defaults
4343
// to the current version of Python used to run `asv`.
44-
"pythons": ["3.10"],
44+
"pythons": ["3.11"],
4545

4646
// The matrix of dependencies to test. Each key is the name of a
4747
// package (in PyPI) and the values are version numbers. An empty
@@ -72,8 +72,12 @@
7272
"sparse": [""],
7373
"cftime": [""]
7474
},
75-
76-
75+
// fix for bad builds
76+
// https://github.com/airspeed-velocity/asv/issues/1389#issuecomment-2076131185
77+
"build_command": [
78+
"python -m build",
79+
"python -mpip wheel --no-deps --no-build-isolation --no-index -w {build_cache_dir} {build_dir}"
80+
],
7781
// Combinations of libraries/python versions can be excluded/included
7882
// from the set to test. Each entry is a dictionary containing additional
7983
// key-value pairs to include/exclude.

0 commit comments

Comments
 (0)
0