GenericModel - Recursive abstract class fails validation #2007
Description
Checks
- I added a descriptive title to this issue
- I have searched (google, github) for similar issues and couldn't find anything
- I have read and followed the docs and still think this is a bug
Bug
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
pydantic version: 1.6.1
pydantic compiled: False
install path: /wayfair/home/ch438l/pydantic/pydantic
python version: 3.6.8 (default, Aug 10 2019, 06:54:07) [GCC 4.8.5 20150623 (Red Hat 4.8.5-36)]
platform: Linux-3.10.0-862.3.2.el7.x86_64-x86_64-with-centos-7.5.1804-Core
optional deps. installed: ['typing-extensions', 'email-validator', 'devtools']
If I try to define an attribute on a generic model to be a generic abstract class, then the model will fail to validate. Here's a failing test case:
@skip_36
def test_abstract_generic_type_recursion():
T = TypeVar('T')
class BaseInnerClass(GenericModel, abc.ABC, Generic[T]):
base_data: T
@abc.abstractmethod
def base_abstract(self) -> None:
pass
class ConcreteInnerClass(BaseInnerClass[T], Generic[T]):
def base_abstract(self) -> None:
return None
class OuterClass(GenericModel, Generic[T]):
inner_class: BaseInnerClass[T]
OuterClass[int](inner_class=ConcreteInnerClass[int](base_data=2))It appears to be failing because the isinstance(value, cls) check is failing for the generic type.