fix: avoid multiple calls of __post_init__ when dataclasses are inherited (#4493)

PrettyWood · web-flow · commit a825106c2c5f · 2022-12-29T11:18:00.000+01:00
diff --git a/changes/4487-PrettyWood.md b/changes/4487-PrettyWood.md
@@ -0,0 +1 @@
+fix: avoid multiple calls of `__post_init__` when dataclasses are inherited
diff --git a/pydantic/dataclasses.py b/pydantic/dataclasses.py
@@ -288,7 +288,10 @@ def handle_extra_init(self: 'Dataclass', *args: Any, **kwargs: Any) -> None:
             init(self, *args, **kwargs)
 
     if hasattr(dc_cls, '__post_init__'):
-        post_init = dc_cls.__post_init__
+        try:
+            post_init = dc_cls.__post_init__.__wrapped__  # type: ignore[attr-defined]
+        except AttributeError:
+            post_init = dc_cls.__post_init__
 
         @wraps(post_init)
         def new_post_init(self: 'Dataclass', *args: Any, **kwargs: Any) -> None:
diff --git a/tests/test_dataclasses.py b/tests/test_dataclasses.py
@@ -1474,6 +1474,31 @@ def __post_init__(self):
     assert C().a == 6  # 1 * 3 + 3
 
 
+def test_inheritance_post_init_2():
+    post_init_calls = 0
+    post_init_post_parse_calls = 0
+
+    @pydantic.dataclasses.dataclass
+    class BaseClass:
+        def __post_init__(self):
+            nonlocal post_init_calls
+            post_init_calls += 1
+
+    @pydantic.dataclasses.dataclass
+    class AbstractClass(BaseClass):
+        pass
+
+    @pydantic.dataclasses.dataclass
+    class ConcreteClass(AbstractClass):
+        def __post_init_post_parse__(self):
+            nonlocal post_init_post_parse_calls
+            post_init_post_parse_calls += 1
+
+    ConcreteClass()
+    assert post_init_calls == 1
+    assert post_init_post_parse_calls == 1
+
+
 def test_dataclass_setattr():
     class Foo:
         bar: str = 'cat'

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+fix: avoid multiple calls of `__post_init__` when dataclasses are inherited