Improve error thrown when overriding field with a property (#11459)

sydney-runkle · Viicos · web-flow · commit 7ccad67149c3 · 2025-02-19T17:12:31.000Z
Co-authored-by: Victorien &lt;65306057+Viicos@users.noreply.github.com&gt;
diff --git a/pydantic/_internal/_fields.py b/pydantic/_internal/_fields.py
@@ -264,7 +264,10 @@ def collect_model_fields(  # noqa: C901
         # to make sure the decorators have already been built for this exact class
         decorators: DecoratorInfos = cls.__dict__['__pydantic_decorators__']
         if ann_name in decorators.computed_fields:
-            raise ValueError("you can't override a field with a computed field")
+            raise TypeError(
+                f'Field {ann_name!r} of class {cls.__name__!r} overrides symbol of same name in a parent class. '
+                'This override with a computed_field is incompatible.'
+            )
         fields[ann_name] = field_info
 
     if typevars_map:
diff --git a/pydantic/fields.py b/pydantic/fields.py
@@ -1421,9 +1421,11 @@ class Child(Parent):
             def a(self) -> str:
                 return 'new a'
 
-    except ValueError as e:
-        print(repr(e))
-        #> ValueError("you can't override a field with a computed field")
+    except TypeError as e:
+        print(e)
+        '''
+        Field 'a' of class 'Child' overrides symbol of same name in a parent class. This override with a computed_field is incompatible.
+        '''
     ```
 
     Private properties decorated with `@computed_field` have `repr=False` by default.
diff --git a/tests/test_computed_fields.py b/tests/test_computed_fields.py
@@ -774,7 +774,9 @@ def test_computed_field_override_raises():
     class Model(BaseModel):
         name: str = 'foo'
 
-    with pytest.raises(ValueError, match="you can't override a field with a computed field"):
+    with pytest.raises(
+        TypeError, match="Field 'name' of class 'SubModel' overrides symbol of same name in a parent class"
+    ):
 
         class SubModel(Model):
             @computed_field
