8000 MinGW support by isuruf · Pull Request #36 · pybind/python_example · GitHub
[go: up one dir, main page]
Skip to content

MinGW support #36

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

MinGW support #36

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7aeb9cc
Check C++11 flags in mingw32 compiler
isuruf Sep 19, 2018
f3e61bf
Fix for temp file on windows
isuruf Sep 19, 2018
6be7a0c
Fix removing directories
isuruf Feb 20, 2019
889c3b8
Revert "Fix removing directories"
isuruf Feb 20, 2019
5264c61
Remove file
isuruf Feb 20, 2019
1983e70
Merge branch 'master' into mingw
isuruf Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,19 @@ def has_flag(compiler, flagname):
"""Return a boolean indicating whether a flag name is supported on
the specified compiler.
"""
import tempfile
with tempfile.NamedTemporaryFile('w', suffix='.cpp') as f:
import tempfile, os
with tempfile.NamedTemporaryFile('w', suffix='.cpp', delete=False) as f:
f.write('int main (int argc, char **argv) { return 0; }')
fname = f.name
try:
compiler.compile([fname], extra_postargs=[flagname])
except setuptools.distutils.errors.CompileError:
return False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for not deleting the temporary file and moving this out of the context manager?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On windows the temp file cannot be opened a second time while
it is still opened by python. Close the file in python before
asking the compiler to read it.

See https://docs.python.org/3.7/library/tempfile.html#tempfile.NamedTemporaryFile

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok it makes sense.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in this case, the file should be deleted later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about something like below, so that I don't have to worry about cleaning up stuff?

    import tempfile, os
    with tempfile.TemporaryDirectory() as d:
        fname = os.path.join(d, 'main.cpp')
        with open(fname, 'w') as f:
            f.write('int main (int argc, char **argv) { return 0; }')
        try:
            compiler.compile([fname], extra_postargs=[flagname])
        except setuptools.distutils.errors.CompileError:
            return False
    return True

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TemporaryDirectory is not in py 2.7. Reverting to deleting the file

finally:
try:
compiler.compile([f.name], extra_postargs=[flagname])
except setuptools.distutils.errors.CompileError:
return False
os.remove(fname)
except OSError:
pass
return True


Expand Down
0