8000 Add GTI DIRINT model by wholmgren · Pull Request #400 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]

Skip to content

Add GTI DIRINT model #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Aug 27, 2018
Merged
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
8a1c3aa
implement gtidirint without iteration
wholmgren Aug 31, 2017
dc4b133
add option to skip aoi > 90
wholmgren Aug 31, 2017
555cd6b
make gti dirint gte 90 function private
wholmgren Aug 31, 2017
fbda8e2
add some gti_dirint tests
wholmgren Aug 31, 2017
bc331f4
implement vectorized iterative solution. fix gt 90 error
wholmgren Sep 7, 2017
003eccb
use azimuth in gt 90 function
wholmgren Sep 7, 2017
880a999
fix some issues near 90 deg
wholmgren Sep 8, 2017
6f881f4
remove unnecessary comment
wholmgren Sep 8, 2017
ac74260
add kt option to disc, dirint to fix gte 90 dni issue
wholmgren Sep 8, 2017
e8b40ea
update whatsnew, add to api.rst
wholmgren Sep 8, 2017
b1a6d48
move to 0.5.2 whatsnew
wholmgren Nov 30, 2017
721f89f
add gti_dirint tutorial
wholmgren Nov 30, 2017
8cd9a74
Merge branch 'master' into gtidirint
wholmgren Jun 16, 2018
abc671c
move changes to 0.6.0 whatsnew
wholmgren Jun 16, 2018
89c60a4
update parameters
wholmgren Jun 16, 2018
376f3f7
fix 0.5.2 whatsnew
wholmgren Jun 16, 2018
5920620
rework max_iterations logic
wholmgren Jun 16, 2018
d856205
flake8
wholmgren Jun 16, 2018
2d99474
update tutorial
wholmgren Jun 16, 2018
0a0feab
api change in whatsnew
wholmgren Jun 16, 2018
ae60316
Merge branch 'master' into gtidirint
wholmgren Aug 14, 2018
870196a
clean up whatsnew
wholmgren Aug 15, 2018
2112825
update to new api. fix parameters
wholmgren Aug 15, 2018
eba99ae
update notebook [skip ci]
wholmgren Aug 15, 2018
a4d2682
refactor
wholmgren Aug 15, 2018
18222d1
more refactoring
wholmgren Aug 15, 2018
4ac71a4
refactor disc and dirint
wholmgren Aug 17, 2018
54521b9
clean up
wholmgren Aug 17, 2018
14915b7
update tutorial
wholmgren Aug 17, 2018
519390a
add stubs. use zeros. more clean up
wholmgren Aug 17, 2018
15ecbf3
review comments
wholmgren Aug 18, 2018
be384b7
Merge remote-tracking branch 'pvlib/master' into gtidirint
wholmgren Aug 19, 2018
c8a470f
rerun on master
wholmgren Aug 19, 2018
6a612dd
some broken tests
wholmgren Aug 21, 2018
cac57cb
update parameters, whatsnew. [skip ci]
wholmgren Aug 21, 2018
c92dd9f
update tests
wholmgren Aug 22, 2018
6c2bf35
update documentation
wholmgren Aug 22, 2018
1b6e5d2
ignore .vscode
wholmgren Aug 24, 2018
e58c7d5
limit clearness index in disc dirint dirindex
wholmgren Aug 24, 2018
0b83533
fix bad change
wholmgren Aug 24, 2018
891f886
update tutorial
wholmgren Aug 24, 2018
ae6a89f
Merge remote-tracking branch 'pvlib/master' into gtidirint
wholmgren Aug 24, 2018
dad4512
remove tutorial
wholmgren Aug 24, 2018
b3f43cb
maybe fix failing py27 test
wholmgren Aug 25, 2018
9eeb67f
doc clean up
wholmgren Aug 25, 2018
6aebf5e
update doi
wholmgren Aug 26, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make gti dirint gte 90 function private
  • Loading branch information
wholmgren committed Nov 30, 2017
commit 555cd6b67e1687e1c2bc14d3aef3b48f550b0ca6
6 changes: 3 additions & 3 deletions pvlib/irradiance.py
Original file line number Diff line number Diff line change
Expand Up @@ -1495,7 +1495,7 @@ def gti_dirint(poa_global, aoi, zenith, surface_tilt, times, pressure=101325.,
# for AOI greater than or equal to 90 degrees

if calculate_gt_90:
ghi_gte_90, dni_gte_90, dhi_gte_90 = gti_dirint_gte_90(
ghi_gte_90, dni_gte_90, dhi_gte_90 = _gti_dirint_gte_90(
poa_global, aoi, zenith, surface_tilt, times, kt_prime,
pressure=pressure, temp_dew=temp_dew, albedo=albedo)
else:
Expand All @@ -1513,8 +1513,8 @@ def gti_dirint(poa_global, aoi, zenith, surface_tilt, times, pressure=101325.,
return output


def gti_dirint_gte_90(poa_global, aoi, zenith, surface_tilt, times, kt_prime,
pressure=101325., temp_dew=None, albedo=.25,):
def _gti_dirint_gte_90(poa_global, aoi, zenith, surface_tilt, times, kt_prime,
pressure=101325., temp_dew=None, albedo=.25,):

# set the kt_prime for sunrise to AOI=90 to be equal to
# the kt_prime for 65 < AOI < 80 during the morning.
Expand Down
0