From 1b483641b275d35043444b4142b8ecbff7a03a1a Mon Sep 17 00:00:00 2001 From: pvlib-benchmarker <77211855+Naman-Priyadarshi@users.noreply.github.com> Date: Wed, 30 Mar 2022 17:40:04 +0530 Subject: [PATCH 1/4] Update Solarposition.py Removed **kwargs from pvlib.solarposition.spa_python --- pvlib/solarposition.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvlib/solarposition.py b/pvlib/solarposition.py index 0e4a120e6e..93465607bb 100644 --- a/pvlib/solarposition.py +++ b/pvlib/solarposition.py @@ -275,7 +275,7 @@ def _spa_python_import(how): def spa_python(time, latitude, longitude, altitude=0, pressure=101325, temperature=12, delta_t=67.0, - atmos_refract=None, how='numpy', numthreads=4, **kwargs): + atmos_refract=None, how='numpy', numthreads=4): """ Calculate the solar position using a python implementation of the NREL SPA algorithm. From 310c0a521d36ccb97c1f9dbb4547e01b51c5544c Mon Sep 17 00:00:00 2001 From: pvlib-benchmarker <77211855+Naman-Priyadarshi@users.noreply.github.com> Date: Tue, 5 Apr 2022 23:38:03 +0530 Subject: [PATCH 2/4] Added v0.9.2.rst, changes in pvlib/irradiance.py and pvlib/location.py Made new v0.9.2.rst and removed **kwargs from pvlib/irradiance.py (Line 309) and pvlib/location.py (Line 234-235) --- docs/sphinx/source/whatsnew/v0.9.2.rst | 26 ++++++++++++++++++++++++++ pvlib/irradiance.py | 2 +- pvlib/location.py | 3 +-- 3 files changed, 28 insertions(+), 3 deletions(-) create mode 100644 docs/sphinx/source/whatsnew/v0.9.2.rst diff --git a/docs/sphinx/source/whatsnew/v0.9.2.rst b/docs/sphinx/source/whatsnew/v0.9.2.rst new file mode 100644 index 0000000000..7cfc74528a --- /dev/null +++ b/docs/sphinx/source/whatsnew/v0.9.2.rst @@ -0,0 +1,26 @@ +.. _whatsnew_0920: + +v0.9.2 (April 5, 2022) +----------------------- + +Deprecations +~~~~~~~~~~~~ + +Enhancements +~~~~~~~~~~~~ + +Bug fixes +~~~~~~~~~ + +Testing +~~~~~~~ + +Documentation +~~~~~~~~~~~~~ + +Requirements +~~~~~~~~~~~~ + +Contributors +~~~~~~~~~~~~ +* Naman Priyadarshi (:ghuser:`Naman-Priyadarshi`) diff --git a/pvlib/irradiance.py b/pvlib/irradiance.py index c5c3b1c095..3de4d96f65 100644 --- a/pvlib/irradiance.py +++ b/pvlib/irradiance.py @@ -306,7 +306,7 @@ def get_total_irradiance(surface_tilt, surface_azimuth, dni, ghi, dhi, dni_extra=None, airmass=None, albedo=.25, surface_type=None, model='isotropic', - model_perez='allsitescomposite1990', **kwargs): + model_perez='allsitescomposite1990'): r""" Determine total in-plane irradiance and its beam, sky diffuse and ground reflected components, using the specified sky diffuse irradiance model. diff --git a/pvlib/location.py b/pvlib/location.py index 104fccac89..ddd2d1b96a 100644 --- a/pvlib/location.py +++ b/pvlib/location.py @@ -231,8 +231,7 @@ def get_clearsky(self, times, model='ineichen', solar_position=None, pressure = atmosphere.alt2pres(self.altitude) if solar_position is None: - solar_position = self.get_solarposition(times, pressure=pressure, - **kwargs) + solar_position = self.get_solarposition(times, pressure=pressure) apparent_zenith = solar_position['apparent_zenith'] apparent_elevation = solar_position['apparent_elevation'] From 3a0a8cceb5fd8e06bb6496482afc49151faa176b Mon Sep 17 00:00:00 2001 From: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com> Date: Wed, 6 Apr 2022 12:27:10 -0600 Subject: [PATCH 3/4] Update docs/sphinx/source/whatsnew/v0.9.2.rst --- docs/sphinx/source/whatsnew/v0.9.2.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.9.2.rst b/docs/sphinx/source/whatsnew/v0.9.2.rst index 7cfc74528a..8dcb3f3138 100644 --- a/docs/sphinx/source/whatsnew/v0.9.2.rst +++ b/docs/sphinx/source/whatsnew/v0.9.2.rst @@ -1,6 +1,6 @@ .. _whatsnew_0920: -v0.9.2 (April 5, 2022) +v0.9.2 (TBD) ----------------------- Deprecations From e21b0799ef2697f40a0469642e4576acbc3fedd8 Mon Sep 17 00:00:00 2001 From: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com> Date: Wed, 6 Apr 2022 12:27:15 -0600 Subject: [PATCH 4/4] Update docs/sphinx/source/whatsnew/v0.9.2.rst --- docs/sphinx/source/whatsnew/v0.9.2.rst | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.9.2.rst b/docs/sphinx/source/whatsnew/v0.9.2.rst index 8dcb3f3138..4f2dbce094 100644 --- a/docs/sphinx/source/whatsnew/v0.9.2.rst +++ b/docs/sphinx/source/whatsnew/v0.9.2.rst @@ -11,7 +11,10 @@ Enhancements Bug fixes ~~~~~~~~~ - +* :py:func:`pvlib.irradiance.get_total_irradiance` and + :py:func:`pvlib.solarposition.spa_python` now raise an error instead + of silently ignoring unknown parameters (:ghpull:`1437`) + Testing ~~~~~~~